[FIX] website_airproof: load templates in correct order #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The carousel template file was loaded too late in the manifest data sequence, causing a ParseError when new_page_templates tried to reference it. X-original-commit: 34d70b5
|
|
|
This PR targets 19.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the loading order issue in the Airproof tutorial that causes module installation to fail.
Problem
The
s_airproof_carouseltemplate was referenced innew_page_templatesbefore being loaded into the database, causing:Solution
Moved
'views/snippets/options.xml',andviews/snippets/s_airproof_carousel.xmlto the beginning of the data list in__manifest__.pyto ensure the template is loaded before being referenced.Changes
__manifest__.pyto load templates firstTesting
Related Issues
Closes #981
Checklist
Forward-Port-Of: #982