Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Gradle refactoring #467

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Gradle refactoring #467

merged 3 commits into from
Mar 15, 2023

Conversation

planetf1
Copy link
Member

@planetf1 planetf1 commented Mar 1, 2023

Initial PR for refactoring of gradle dependencies

  • Uses shadow plugin for building uber jars
  • Moves version specs to dependency constraints
  • updates plugin versions
  • Ensures project/build health run for both projects
  • removes most tasks from top level project - no need to publish it
  • cleans up dependencies as reported by dependency analysis plugin

Caveats

  • Ideally we'd depend on the egeria BOM, but this is currently broken for v4

Todo

  • identify runtime dependencies for migrator (any additional to core connector?)
  • test connector & migrator

Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1 planetf1 marked this pull request as draft March 1, 2023 11:44
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
@planetf1
Copy link
Member Author

planetf1 commented Mar 14, 2023

The platform spec can now be imported following availability of odpi/egeria#7499
Note that currently there are dependency constraints that can now be removed

@cmgrote can you advise how I should test. Anything needed beyond what we currently have in gradle (at least for now)

If not can you take a look at the changes and see if they make sense?

I can finish the gradle cleanup in this, or a later PR -- keen to get this merged and test in the automated cts (xtdb currently failing as we know due to the v4 changes)

@planetf1 planetf1 marked this pull request as ready for review March 14, 2023 17:58
@planetf1 planetf1 requested a review from cmgrote March 14, 2023 17:58
@planetf1
Copy link
Member Author

planetf1 commented Mar 15, 2023

I am proposing to merge this late today or tomorrow so that we can validate the new BOM support for v4, and have the automated CTS run against XTDB - there may be further work on all of these & we're approaching branch time for r4 in about a week.

The changes proposed are packaging only (of course that affects runtime)

build.gradle Show resolved Hide resolved
@cmgrote
Copy link
Member

cmgrote commented Mar 15, 2023

Makes sense to me — if you can just confirm on the question I raised above (assuming this doesn't pull in all those dependencies), let's go ahead and merge. I won't have a chance to do much of a deeper review over the next couple of days.

@planetf1 planetf1 merged commit 09e1702 into odpi:main Mar 15, 2023
@planetf1 planetf1 deleted the gradleupd2 branch March 15, 2023 11:39
@planetf1
Copy link
Member Author

I am aware the aggregate javadoc is broken. Will fix as I test the connector works with 4.0 .. later this week.

I had missed checking that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants