Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace log4j logger with slf4j in java files #62

Closed
bogdan-sava opened this issue Jul 11, 2018 · 2 comments
Closed

Replace log4j logger with slf4j in java files #62

bogdan-sava opened this issue Jul 11, 2018 · 2 comments
Assignees

Comments

@bogdan-sava
Copy link
Contributor

No description provided.

@bogdan-sava bogdan-sava self-assigned this Jul 11, 2018
@planetf1
Copy link
Member

Do we need to go anything in the build to reduce the chance of including the circular log4j/slf adapter relationship?

Would something like the rules for maven enforcer at https://tenmilesquare.com/utilizing-maven-enforcer-plugin-to-ensure-dependency-and-version-usage/ help add this validation in one place, and avoid errors downstream in our poms?

Additionally #22 is a change in how we express our own dependencies, which can affect transitive dependency resolution?

@planetf1
Copy link
Member

One proposal - make the slf change, and then add this enforcement if we see it appear again and find it helps prevent the error. If not leave as is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants