Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Atlas docker and k8s changes #1127

Merged
merged 23 commits into from
Jul 2, 2019
Merged

Apache Atlas docker and k8s changes #1127

merged 23 commits into from
Jul 2, 2019

Conversation

cmgrote
Copy link
Member

@cmgrote cmgrote commented Jun 14, 2019

  • Configures vanilla Apache Atlas container to tail all log files by default (not only application.log)
  • Adds container-external accessibility to embedded Apache Atlas Kafka event bus
  • Adds parameters for Apache Atlas container (eg. credentials, endpoints, etc)
  • Swaps forked Apache Atlas container as default to the vanilla Apache Atlas container
  • Configures Apache Atlas proxy as part of egeria container itself, rather than a separate container

cmgrote added 15 commits May 30, 2019 12:37
Signed-off-by: Christopher Grote <chris@thegrotes.net>
…sses, not just localhost

Signed-off-by: Christopher Grote <chris@thegrotes.net>
… uses .out logs instead of application.log

Signed-off-by: Christopher Grote <chris@thegrotes.net>
Signed-off-by: Christopher Grote <chris@thegrotes.net>
…arate proxy

Signed-off-by: Christopher Grote <chris@thegrotes.net>
Signed-off-by: Christopher Grote <chris@thegrotes.net>
Signed-off-by: Christopher Grote <chris@thegrotes.net>
Signed-off-by: Christopher Grote <chris@thegrotes.net>
@cmgrote cmgrote requested a review from planetf1 as a code owner June 14, 2019 11:49
Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What level of capability do we now have in the atlas proxy connector compared to the temporary native connector - at least in terms of an integrated deployment

Clearly we will lose the ability to write to atlas (as covered in other issues) but we will have a more strategic environment.

The main use of atlas I've seen from users so far is in terms of UI. The subject area UI is now available, and the type explorer, and other viewers are coming soon - so the only question for me now is whether it's ok to drop atlas writeability before those alternate UIs are in place (and within the chart)

An alternative is to retain use of the old image -- but this does make the scripts more complex

If we do move entirely to the new image

  • we can remove the old image from the build process entirely

@planetf1
Copy link
Member

From a development perspective it's a good change... I'll float the suggestion with a few people I currently have pulling the charts to check for impact before merging

@planetf1
Copy link
Member

I've confirmed at least one user is making use of atlas ui for browsing. Likely terms/glossaries. I noted current UI is failing also so opened up #1129

I suggest we need to hold off merging just yet.

Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.
Just adding a request mark whilst we assess/mitigate the impact for any existing users

@cmgrote
Copy link
Member Author

cmgrote commented Jun 14, 2019

Sure thing -- let's leave open for now. I was under the impression that the forked Atlas build may be broken already, in which case this was at least something. But if not, let's leave as-is for now 👍

@planetf1
Copy link
Member

planetf1 commented Jun 17, 2019

Ok. I will double check if it works now (it was ok), but have a few people confirm they are using it. Obviously if we make it optional then we can merge now. I think the availability of Egeria UIs will allow us to make the change finally as I completely agree in not wanting to prolong the use of forked atlas much longer, and the main use-case for Atlas right now seems to be visualizing the contents of egeria!

@schannamallu
Copy link

recheck

@planetf1
Copy link
Member

Can confirm 'old' atlas is working propertly, so continuing to wait until new UI is available in lieu of atlas UI for simple search

…hanged

Signed-off-by: Christopher Grote <chris@thegrotes.net>
…hanged

Signed-off-by: Christopher Grote <chris@thegrotes.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants