sendEvents Async #7138
Merged
sendEvents Async #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadPool to not spawn a lot of threads that do small work. Reworked the OMRSTopic interface to support async send, made minimal changes (sendInstance event is not checked, but it could be changed for consistency) Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
marius-patrascu
requested review from
popa-raluca,
lcpopa and
mandy-chessell
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...ta/repositoryservices/connectors/openmetadatatopic/OpenMetadataTopicSenderConnectorBase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
...ta/repositoryservices/connectors/openmetadatatopic/OpenMetadataTopicSenderConnectorBase.java
Outdated
Show resolved
Hide resolved
lpalashevski
approved these changes
Nov 29, 2022
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Outdated
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Outdated
Show resolved
Hide resolved
...ta/repositoryservices/connectors/openmetadatatopic/OpenMetadataTopicSenderConnectorBase.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 29, 2022 17:40
Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
...ta/repositoryservices/connectors/openmetadatatopic/OpenMetadataTopicSenderConnectorBase.java
Outdated
Show resolved
Hide resolved
lpalashevski
requested changes
Dec 1, 2022
Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
Signed-off-by: marius-patrascu <marius-florin.patrascu@ing.com>
lpalashevski
approved these changes
Jan 20, 2023
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/7138.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/7138.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
|
This change was functionally tested and validated. No functional regression found.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marius-patrascu marius-florin.patrascu@ing.com
Description
Send instance, types, registrations events async. Use the default threadPool to not spawn a lot of threads that do small work. Reworked the OMRSTopic interface to support async send, made minimal changes (sendInstance event is not checked, but it could be changed for consistency)
Testing
Build, UT, FVT, UI, manual