Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JDBC and Atlas connectors #7827

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Upgrade JDBC and Atlas connectors #7827

merged 2 commits into from
Aug 22, 2023

Conversation

mandy-chessell
Copy link
Contributor

Description

This fix includes:

  • Extensions to the JDBC resource connector to allow it to issue SQL queries
  • Bug fixes the the Apache Atlas integration connector
  • Support for a new AuditLog severity called "Activity" that is used to monitor user calls to the REST API and activity (create, update, read etc) around specific assets. The aim is to provide observability of the most popular assets and the most active users.
  • New type called RelationalDatabase that inherits from Database. It indicates that the database spport the relational schema and can be called via JDBC.

Related Issue(s)

None

Testing

Tested using the labs and also build an integration connector to load metadata from Egeria into a relational database.

Release Notes & Documentation

These updates have already been added to the docs site.

Additional notes

None

@mandy-chessell
Upgrade JDBC and Atlas connectors
f1802ed 
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
@mandy-chessell mandy-chessell merged commit 1cd21b1 into odpi:main Aug 22, 2023
4 checks passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2023
View reviewed changes
...ava/org/odpi/openmetadata/adapters/connectors/integration/jdbc/JDBCIntegrationConnector.java
*/
@Override
public void initializeEmbeddedConnectors(List<Connector> embeddedConnectors)
public void start() throws ConnectorCheckedException

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
ConnectorBase.start
; it is advisable to add an Override annotation.
This method overrides
IntegrationConnector.start
; it is advisable to add an Override annotation.
...ava/org/odpi/openmetadata/adapters/connectors/integration/jdbc/JDBCIntegrationConnector.java
*/
@Override
public void initializeEmbeddedConnectors(List<Connector> embeddedConnectors)
public void start() throws ConnectorCheckedException

Check warning

Code scanning / CodeQL

Non-synchronized override of synchronized method Warning

Method 'start' overrides a synchronized method in
org.odpi.openmetadata.frameworks.connectors.ConnectorBase
but is not synchronized.
...main/java/org/odpi/openmetadata/adapters/connectors/resource/jdbc/JDBCResourceConnector.java

if (connectionTimeoutOption != null)
{
int connectionTimeout = Integer.parseInt(connectionTimeoutOption.toString());

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
...n/java/org/odpi/openmetadata/frameworkservices/gaf/server/OpenMetadataStoreRESTServices.java
* PropertyServerException there is a problem accessing the metadata store
*/
public RelatedMetadataElementsResponse getRelationshipByGUID(String serverName,
String serviceURLMarker,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'serviceURLMarker' is never used.
...n/java/org/odpi/openmetadata/frameworkservices/gaf/server/OpenMetadataStoreRESTServices.java
String serviceURLMarker,
String userId,
String relationshipGUID,
boolean forLineage,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'forLineage' is never used.
...n/java/org/odpi/openmetadata/frameworkservices/gaf/server/OpenMetadataStoreRESTServices.java
String userId,
String relationshipGUID,
boolean forLineage,
boolean forDuplicateProcessing,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'forDuplicateProcessing' is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planetf1 planetf1 Awaiting requested review from planetf1

@lcpopa lcpopa Awaiting requested review from lcpopa lcpopa is a code owner

@popa-raluca popa-raluca Awaiting requested review from popa-raluca popa-raluca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mandy-chessell