Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/setup new module structure #21

Merged
merged 62 commits into from
Feb 19, 2020
Merged

Conversation

jnnr
Copy link
Member

@jnnr jnnr commented Jan 21, 2020

  • Fix error importing cartopy

TODO

Structure

  • Setup general structure sketched in Module structure to be settled #14
    • Do consistency checks
    • Assert that required parameters are defined
    • Set default values
    • Models and results

Clean up

  • Write docstrings
  • Add module headers
  • Render components and components_attrs in docs
  • Check if examples are working
  • Fix failing tests and linters
    • Fix error on installation when installing rtree

@jnnr jnnr self-assigned this Feb 17, 2020
@jnnr jnnr added this to the Move to oemof milestone Feb 17, 2020
@jnnr jnnr marked this pull request as ready for review February 19, 2020 10:33
@jnnr jnnr merged commit c689080 into dev Feb 19, 2020
@jnnr jnnr deleted the features/setup-new-module-structure branch February 19, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant