-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/update naming #43
Conversation
@@ -40,8 +40,8 @@ class InteractiveMap(): | |||
""" | |||
def __init__(self, thermal_network): | |||
self.node_data = self.collect_node_data(thermal_network) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert everything to edges, except for
self.edge_data = thermal_network.components.pipes
@@ -48,23 +48,23 @@ | |||
# get building data | |||
areas = footprints.area | |||
|
|||
# get nodes and edges from graph | |||
nodes, edges = ox.save_load.graph_to_gdfs(graph) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is streets that one gets from osmnx. More abstract: Edges. Stay with edges?
Should add in components.csv's description that pipes have a defined direction. |
it seems that sometimes |
The idea of this PR is to rename edges to pipes because that name is more concrete. At some places in functions that handle networkx graphs I decided that it is more natural to keep talking of edges, as the function is more abstract (see the last commits). What you propose is to use the two terms, edges and pipes, to discriminate beetween potential pipes and existing pipes. I would like to call them one of the two, edges or pipes. As we discussed this in an issue and there were no objections for quite a while, I would like to stay with 'pipes'. Then we indicate the distinction of presence or not by setting the attribute 'pipe_type', 'capacity' to None and 0 if it does not exist and some value if it exists. See #44. |
Okay, let's do it this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort! I reverted the renaming in those cases where the code talks about graphs in a more abstract sense.
With this PR the naming is adjusted from 'edges' to 'pipes' as suggested in issue #38