Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random CI failure: gas limit reached, no contract code at given address #142

Closed
PlasmaPower opened this issue Jan 12, 2022 · 5 comments
Closed
Labels

Comments

@PlasmaPower
Copy link
Collaborator

https://github.com/OffchainLabs/nitro/actions/runs/1688575887/attempts/1

@PlasmaPower
Copy link
Collaborator Author

This comment in geth might be relevant:

	// Check that code has indeed been deployed at the address.
	// This matters on pre-Homestead chains: OOG in the constructor
	// could leave an empty account behind.

if our test L1 is pre-homestead, the receipt from the deploy could indicate a success, but it could actually be out of gas.

@PlasmaPower
Copy link
Collaborator Author

Might be fixed by overriding the gas limit for l1 deploys in #148

@PlasmaPower
Copy link
Collaborator Author

Seems to have been fixed by #165

@PlasmaPower
Copy link
Collaborator Author

Nevermind, maybe not

@PlasmaPower
Copy link
Collaborator Author

Fixed by #185; I haven't seen this in a while

rachel-bousfield added a commit that referenced this issue Apr 19, 2024
Ferret-san pushed a commit to celestiaorg/nitro that referenced this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant