Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted investigation and investigation group data into JSON #1912

Merged
merged 12 commits into from
May 15, 2024
Merged

converted investigation and investigation group data into JSON #1912

merged 12 commits into from
May 15, 2024

Conversation

DraKen0009
Copy link
Contributor

Proposed Changes

  • converted the data present populate_investigation.py from string to json

Associated Issue

Merge Checklist

  • tested using python manage.py populate_investigations

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

rithviknishad
rithviknishad requested changes Feb 25, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the data outside of the python code in a JSON file. (Like how we have for ICD11 and Medibase)

@DraKen0009
Copy link
Contributor Author

@rithviknishad made the required changes , please have a look

@sainak
Copy link
Member

sainak commented Feb 26, 2024

@DraKen0009 the changes look, one final step is to update the data from this sheet

@DraKen0009
Copy link
Contributor Author

@sainak do we need to update the data according to comment before ?
image

Updated to -
image

@DraKen0009
Copy link
Contributor Author

Also the data at the bottom of the table is not accurate (min, max values)
image

I can update them accordingly and update the json file with it.

@sainak
Copy link
Member

sainak commented Feb 26, 2024 •
edited
Loading

@DraKen0009

do we need to update the data according to comment before ?

yes, the comments in the last column of the sheet

the rows marked yellow needs to be updated, and the ones marked red needs to be deleted

Also the data at the bottom of the table is not accurate (min, max values)

which rows are you referring to?

@DraKen0009
Copy link
Contributor Author

135-145 ( what i have currently noticed)

  • like in line 135
    Min should be 11 and max should be 18
    But given 0 and 25

@sainak
Copy link
Member

sainak commented Feb 26, 2024

135-145 ( what i have currently noticed)

* like in line 135
  Min should be 11 and max should be 18
  But given 0 and 25

I think what you are referring to is ideal value, that is its mentioned in the col just before min, which needs to be added in the model as well, min and max look okay to me

@sainak sainak requested a review from Ashesh3 March 1, 2024 12:11
@sainak sainak requested review from rithviknishad and removed request for rithviknishad March 2, 2024 12:06
@sainak sainak added the blocked label Mar 4, 2024
sainak
sainak requested changes Mar 30, 2024
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • make investigation names unique, and add suffix to duplicate values in db
  • find and rename duplicates in data/investigations.json
  • use upsert to create or update data

@sainak sainak added the to-be-closed PRs with no updates in the last 3 weeks will be closed label May 12, 2024
@sainak sainak added changes required and removed waiting-for-review to-be-closed PRs with no updates in the last 3 weeks will be closed labels May 12, 2024
@sainak sainak reopened this May 12, 2024
@sainak sainak requested a review from a team as a code owner May 12, 2024 12:06
@sainak
Copy link
Member

sainak commented May 14, 2024

@rithviknishad review required

@vigneshhari vigneshhari merged commit a5171a8 into ohcnetwork:develop May 15, 2024
3 checks passed
vigneshhari added a commit that referenced this pull request May 15, 2024
@nihal467 @bodhish
@rithviknishad @vigneshhari @sainak @khavinshankar @gigincg @rash-27 @shivankacker @DraKen0009 @GokulramGHV
Merge Develop to Staging v24.21.0 (#2168)
5d0158d 
* Update max_length for phone numbers to adhere to ITU-T E.164 standard (#2138)

* Update max_length for phone numbers to adhere to ITU-T E.164 standard

* Clean up an empty line

* Adds missing migrations

---------

Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Adds support for doctors and nurses discussions threads in Discussion Notes (#2137)

* Adds support for doctors and nurses discussions threads in Discussion Notes

* switch to using small integer field

* updated and fixes based on test cases

* rebase migrations

* Remake migrations

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Allow `audio/mp4` by default (#2094)

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Bump Dependencies (#2143)

* Vigneshhari/bump dependencies (#2145)

* Bump Dependencies

* Bump Dependencies

* Bump Dependencies

* Bump Dependencies

* Skip creating event group if all fields are null (#2134)

* ABDM M3 (#1829)

Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: Gigin George <mail.gigin@gmail.com>

* Increase area of specialisation in doctors (#2102)

* update doctor types

* Add Migration

---------

Co-authored-by: Rithvik Nishad <rithvik.nishad@egovernments.org>
Co-authored-by: Gigin George <mail.gigin@gmail.com>

* Added discharge patient filters (#2124)

* added discharge patient filters

* updated filters

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* converted investigation and investigation group data into JSON (#1912)

* converted investigation and investigation group data into JSON

* created json files for investigations and investigation_groups

* updated investigations.json

* fixed json data,command and migrations

* fixing migrations

* fixing lint issue

* update migrations

* update migrations

---------

Co-authored-by: Aakash Singh <mail@singhaakash.dev>

* Drops support for cloning previous log update (#2127)

* Drop support for cloning previous log update

* undo unrelated changes

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Change devcontainer make up command to run after start (#2146)

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Removes unused `current_health` field from Daily Rounds (#2162)

Removes unused `current_health` from Daily Rounds

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Display users list based on user access limitation (#1742)

* Refactor get_queryset method in UserViewSet

* Used get_accessible_facilities instead of subquery
to fetch the facilities linked to the user

* fixed failing tests

* fix queryset

---------

Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: khavinshankar <khavinshankar@gmail.com>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* adds missing merge migrations (#2169)

merge migrations

---------

Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>
Co-authored-by: Rithvik Nishad <rithvik.nishad@egovernments.org>
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Co-authored-by: Gigin George <mail.gigin@gmail.com>
Co-authored-by: Rashmik <146672184+rash-27@users.noreply.github.com>
Co-authored-by: Shivank Kacker <kacker.shivank@gmail.com>
Co-authored-by: Prafful Sharma <115104695+DraKen0009@users.noreply.github.com>
Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@sainak sainak sainak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DraKen0009 @sainak @Ashesh3 @vigneshhari @rithviknishad @gigincg