Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused context from Form Fields due to unnecessary complexity #7983

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 6, 2024

Proposed Changes

  • Drop unused context from Form Fields.
  • Decreased complexity of form fields
  • Improved type safety (removed 15 any types)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner June 6, 2024 06:41
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 7:13am

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f93c341
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/666161413218500008aebb41
😎 Deploy Preview https://deploy-preview-7983--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 6, 2024

Passing run #2705 ↗︎

0 124 0 0 Flakiness 0

Details:

Drop unused `context` from Form Fields due to unnecessary complexity
Project: CARE Commit: f93c341969
Status: Passed Duration: 02:55 💡
Started: Jun 6, 2024 7:16 AM Ended: Jun 6, 2024 7:19 AM

Review all test suite changes for PR #7983 ↗︎

@nihal467
Copy link
Member

LGTM and cypress is passing

@khavinshankar khavinshankar merged commit a62d3d1 into develop Jun 14, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/remove-unused-complex-abstractions-of-formfield-context branch June 14, 2024 01:47
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants