Fix array search compatibility in RangeAutocompleteFormField #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@gigincg can you review the PR? |
Passing run #2754 ↗︎
Details:
Review all test suite changes for PR #8021 ↗︎ |
|||||||||||||||
khavinshankar
approved these changes
Jun 14, 2024
khavinshankar
approved these changes
Jun 14, 2024
|
@bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8020
Updates the
RangeAutocompleteFormFieldcomponent to ensure compatibility with older browsers by replacing theArray.findLast()method with a combination ofArray.reverse()andArray.find().findLastwith a sequence of creating a shallow copy of the thresholds array, reversing it, and then usingfindto locate the desired threshold. This change avoids mutating the original array and ensures the functionality is supported across all targeted browser environments.For more details, open the Copilot Workspace session.