Added perms plugin

[roryhardy]

I added a new plugin for recursively setting all files' permissions to 644 recursively in a directory and for recursively setting all directories' permissions to 755.

This has been useful primarily for websites, but I've found other uses for it. I also wrote a function to do both at the same time with verification.

[robbyrussell]

@gneatgeek Could you include a README for this?

[roryhardy]

Done! My apologies for the delayed response.

[roryhardy]

@robbyrussell ping

[apjanke]

A couple items:

• The -exec chmod {} form is going to be slow on large directories. How about find | xargs chmod, at least as a default?
• The while loop logic is a little hard to understand, since it looks like it's only going to make one pass regardless. This looks like a holdover from an alternate form that could process multiple target directories.
• The if branch for handling whether the user supplied a target or it defaulted to $PWD duplicates a lot of code. Might be cleaner to set the target directory based on input up front, and then apply a single path of find/chmod logic to it.
• The -d $1 test checks whether something is a directory, so if the user supplies a target argument, but it happens to be a symlink or normal file, or a nonexistent file (like if they made a typo), it falls back to targeting $PWD instead. That's probably not what the user intended.
  • Since only the basename of the target dir is displayed in the confirmation message, there are even cases where the user couldn't tell if this happened by reading the message, if their intended target had a basename similar to the $PWD they were in.
• Exit status doesn't reflect the exit status of the find and chmod operations.
• Since prompting is unconditional, might want to restrict this to interactive or tty-attached shells.
• OMZ typically uses zsh style [[ ... ]] instead of sh-compatible [ ... ] tests.

How about this?

[roryhardy]

Thanks @apjanke, sorry for the year late response! Somehow this one slipped through the cracks. I haven't had a chance to test the code yet, but your solution looks good to me. I'll try it out this evening and update this pull request accordingly.

[roryhardy]

@apjanke, I made some minor tweaks, but it looks like it's working out great. Thanks! @robbyrussell do find this acceptable at this time?

[roryhardy]

@robbyrussell, @apjanke, and @mcornella, is there anything else that this needs from me?

[mcornella]

You can use zsh globbing to select all files in the current directory and subdirectories: chmod 644 **/*(.)

[mcornella]

I've left a couple of suggestions that could improve the code, but as is the plugin is more than ok to merge. Besides, this must be the oldest one yet to be merged haha.

Thanks for your work!

[roryhardy]

Thanks for the tips and for merging the pull requests @mcornella! :)