Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in the data organization #29

Closed
lheisler opened this issue May 16, 2019 · 1 comment
Closed

Fix inconsistencies in the data organization #29

lheisler opened this issue May 16, 2019 · 1 comment

Comments

@lheisler
Copy link
Contributor

Analysis (and possibly clinical) data is attached to objects using keys, and these keys are used for validation and for downtream decision making.

The way these are set up are inconsistent between data types.

for Mutation data, the key is simply MAF, which is a data type
for Expression data the key is MRNA_EXPRESSION, which is an alteration type (can have three data types, Continuous, discrete, z-score)
for Copy number data the key is a data type (SEG or continuous).

Data types are not unique across alteration types.
The key is better set at Alteration_type:data_type

This will require modifications to the organization of the data, and downstream decision making.

lheisler added a commit that referenced this issue May 16, 2019
…ta is referenced. ALTERATIONTYPE:DATATYPE is now a general unique value used as a key for both validation of information and decisions making on how to process. ALL test pipelines appear to be working, will merge this to the master and extend development further on the dev branch
@lheisler
Copy link
Contributor Author

This took quite a bit of testing to implement, but all seems to be in place. All tests passed at this point, it is possible that there are other parts of the code that need to be accounted for and will keep this in mind with further development. These corrections will allow better extensibility, and implementation of new pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant