Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/components): support for Iconify icons #101

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

ojvribeiro
Copy link
Owner

@ojvribeiro ojvribeiro commented Dec 13, 2022

Resolves #87.

The original idea is to use the name prop to use custom icons on the assets/icons folder and the icon prop for the Iconify icons.

e.g.:

<!-- Vulmix custom icons -->
<Icon name="my-icon" />

<!-- Iconify icons -->
<Icon icon="ic:baseline-accessibility-new" />

@ojvribeiro ojvribeiro marked this pull request as ready for review December 14, 2022 02:13
@ojvribeiro ojvribeiro mentioned this pull request Dec 14, 2022
3 tasks
@ojvribeiro ojvribeiro merged commit 87f05a1 into main Dec 14, 2022
@ojvribeiro ojvribeiro deleted the feat/iconify-support-for-icon-component branch December 14, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍰 nice-to-have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Vulmix's Icon component with Iconify
1 participant