Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sidebar #514

Merged
merged 26 commits into from
Aug 25, 2024
Merged

Implement sidebar #514

merged 26 commits into from
Aug 25, 2024

Conversation

guergana
Copy link
Collaborator

Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: e588f19
Status: ✅  Deploy successful!
Preview URL: https://be70c2ce.opendataeditor.pages.dev
Branch Preview URL: https://506-sidebar-implementation.opendataeditor.pages.dev

View logs

client/components/Parts/Trees/File.tsx Outdated Show resolved Hide resolved
client/themes.ts Show resolved Hide resolved
@romicolman
Copy link
Collaborator

I tested the implementation on Mac:

  • Files with errors: OK
  • Files with no errors: OK
  • Report an issue feature: OK
  • User guide: OK
  • Icon to identify folders: it is missing in this new implementation. We need to add it to make sure that the user understands trees. How it looks right now (Prueba csv is a folder):
Captura de pantalla 2024-08-19 a la(s) 9 29 58 a  m

I also tested the Upload your data button:

  • Uploading a csv: it works OK
  • Uploading an external data: it works OK but, I do not see red or green dot (with or without errors) next to Google Sheets:
Captura de pantalla 2024-08-19 a la(s) 9 34 45 a  m

I also tested the implementation using this link and this one and it works. So I think it is something associated with Google Sheets.

I also uploaded a folder with two Csvs and it seems to be a problem with icons (please, take a look at the first one):

Captura de pantalla 2024-08-19 a la(s) 9 39 07 a  m

The rest seems OK. Please, let me know if you want to merge changes and I create a separate ticket with all these issues.

@guergana
Copy link
Collaborator Author

guergana commented Aug 19, 2024

I tested the implementation on Mac:

* Files with errors: OK

* Files with no errors: OK

* Report an issue feature: OK

* User guide: OK

* Icon to identify folders: it is missing in this new implementation. We need to add it to make sure that the user understands trees. How it looks right now (**Prueba csv** is a folder):
Captura de pantalla 2024-08-19 a la(s) 9 29 58 a  m

I also tested the Upload your data button:

* Uploading a csv: it works OK

* Uploading an external data: it works OK but, I do not see red or green dot (with or without errors) next to Google Sheets:
Captura de pantalla 2024-08-19 a la(s) 9 34 45 a  m

I also tested the implementation using this link and this one and it works. So I think it is something associated with Google Sheets.

I also uploaded a folder with two Csvs and it seems to be a problem with icons (please, take a look at the first one):
Captura de pantalla 2024-08-19 a la(s) 9 39 07 a  m

The rest seems OK. Please, let me know if you want to merge changes and I create a separate ticket with all these issues.

@romicolman this is not ready for review. you should not have tested this yet. I will let you know when it is ready. Thank for the heads up, though. I know some things are not finished. I have already added [WiP] work in progress to the title.

@guergana guergana changed the title 506 sidebar implementation [WiP] Implement sidebar Aug 19, 2024
@guergana guergana changed the title [WiP] Implement sidebar Implement sidebar Aug 20, 2024
@romicolman
Copy link
Collaborator

Hi all! I tested changes on Mac. Here are my comments:

  • Files with errors: OK
  • Files with no errors: OK
  • Report an issue feature: OK
  • User guide: OK
  • Icon to identify folders: it works ok if you ingest folders, but if you add a new one selecting the create folder button, the icon is missing. It appears AFTER the user ingest data within that folder:
Grabacion.de.pantalla.2024-08-21.a.la.s.8.33.16.a.m.mov

I also tested the Upload your data button:

  • Uploading a csv: it works OK
  • Uploading an external data: it works OK now. I see the icon next to the file after adding the external table.

Copy link
Member

@pdelboca pdelboca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guergana good work guergana! I like the implementation :D

I left some comments regarding some native MUI Components just to know if you tried them and/or have an opinion!

I did found the same issue when Creating a new folder. Since it does not add a folder icon it is confusing what's happening.

client/components/Application/LowerMenu.tsx Show resolved Hide resolved
client/components/Application/Sidebar.tsx Show resolved Hide resolved
test/specs/test.e2e.ts Show resolved Hide resolved
@guergana
Copy link
Collaborator Author

guergana commented Aug 24, 2024

@guergana good work guergana! I like the implementation :D

I left some comments regarding some native MUI Components just to know if you tried them and/or have an opinion!

I did found the same issue when Creating a new folder. Since it does not add a folder icon it is confusing what's happening.

@pdelboca @romicolman Fixed!

@guergana guergana merged commit bb8cc5a into main Aug 25, 2024
9 checks passed
@guergana guergana deleted the 506-sidebar-implementation branch August 25, 2024 10:28
@Faithkenny
Copy link
Collaborator

Hi all!

Some more interaction guidance featuring the context menu. It demonstrates these user actions:

  • Deleting files
  • Folders Expand & collapse
  • Create new folders
  • Deleting folders

Please interact with the Prototype here, and here's the Figma file

Files.and.folders.interactions.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar implementation
4 participants