-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sidebar #514
Implement sidebar #514
Conversation
guergana
commented
Aug 16, 2024
- fixes Sidebar implementation #506
Deploying opendataeditor with Cloudflare Pages
|
Added two colors for now but this should be the way of adding custom colors to the theme.
I tested the implementation on Mac:
I also tested the Upload your data button:
I also tested the implementation using this link and this one and it works. So I think it is something associated with Google Sheets. I also uploaded a folder with two Csvs and it seems to be a problem with icons (please, take a look at the first one): The rest seems OK. Please, let me know if you want to merge changes and I create a separate ticket with all these issues. |
@romicolman this is not ready for review. you should not have tested this yet. I will let you know when it is ready. Thank for the heads up, though. I know some things are not finished. I have already added |
54cb279
to
ad1c7cf
Compare
ad1c7cf
to
d11ee4c
Compare
Hi all! I tested changes on Mac. Here are my comments:
Grabacion.de.pantalla.2024-08-21.a.la.s.8.33.16.a.m.movI also tested the Upload your data button:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guergana good work guergana! I like the implementation :D
I left some comments regarding some native MUI Components just to know if you tried them and/or have an opinion!
I did found the same issue when Creating a new folder. Since it does not add a folder icon it is confusing what's happening.
@pdelboca @romicolman Fixed! |
Hi all! Some more interaction guidance featuring the context menu. It demonstrates these user actions:
Please interact with the Prototype here, and here's the Figma file Files.and.folders.interactions.mp4 |