Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix search-bar does not load on homepage #360

Merged
merged 1 commit into from
Nov 24, 2016
Merged

fix search-bar does not load on homepage #360

merged 1 commit into from
Nov 24, 2016

Conversation

yotammanor
Copy link
Contributor

fix #359.

Improve search-bar jQuery code:

  • set and ID to the search-bar elem.
  • set and ID to the search-bar display button elem.
  • in the code that shows and hides the searchbar, refer to elements by their ID.

@yotammanor
improve search-bar jquery code:
8ea69b4 
- set and ID to the search-bar elem.
- set and ID to the search-bar display button elem.
- in the code that shows and hides the searchbar, refer to elements by their ID.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.2% when pulling 8ea69b4 on yotammanor:feature/359-fix-search-bar-not-loading into 3a698eb on okfn:master.

@yotammanor yotammanor assigned brew and kravets-levko and unassigned brew and kravets-levko Nov 20, 2016
@brew
Copy link
Contributor

brew commented Nov 24, 2016

LGTM

@yotammanor yotammanor merged commit 0f3ac7e into okfn:master Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brew brew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search-bar does not load on homepage
5 participants
@yotammanor @coveralls @brew @pwalsh @kravets-levko