Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py38 compat fixes #376

Merged
merged 5 commits into from
Oct 31, 2019
Merged

py38 compat fixes #376

merged 5 commits into from
Oct 31, 2019

Conversation

kavigupta
Copy link
Contributor

Should fix #375

@kavigupta kavigupta changed the title Update coverage library py38 compat fixes Oct 31, 2019
@kavigupta kavigupta merged commit 5142ed1 into master Oct 31, 2019
@kavigupta kavigupta deleted the update-coverage branch October 31, 2019 10:39
@mehrdadn
Copy link
Contributor

@Sumukh Why are we updating certificates in Python? Or even using custom certificates in the first place? I had a hard time getting what's going on in #209.

itsnshaw added a commit that referenced this pull request Nov 1, 2019
@itsnshaw
Revert "py38 compat fixes (#376)"
b4c113d 
This reverts commit 5142ed1.
itsnshaw added a commit that referenced this pull request Nov 1, 2019
@itsnshaw
Revert "py38 compat fixes (#376)" (#377)
c20a97c 
This reverts commit 5142ed1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrdadn mehrdadn mehrdadn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

‎🚨 ‎🚨 ‎🚨 ‎ok-client DOES NOT WORK ON PYTHON 3.8 ‎🚨 ‎🚨 ‎🚨
2 participants
@kavigupta @mehrdadn