Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to put the code map back into the explorer #27

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Add an option to put the code map back into the explorer #27

merged 2 commits into from
Feb 1, 2020

Conversation

greatpate
Copy link
Contributor

I liked it when the code map was available in the explorer menu, so I added an option for people to be able to move it back there if they want to. The default will be how it is currently (code map explorer)

@oleg-shilo
Copy link
Owner

oleg-shilo commented Feb 1, 2020

Excellent contribution. Will make it into the very next release.
Thank you.

@oleg-shilo oleg-shilo merged commit c2dd8ea into oleg-shilo:master Feb 1, 2020
oleg-shilo pushed a commit that referenced this pull request Feb 4, 2020
* Issue #27: Add an option to put the code map back into the explorer.
@oleg-shilo
Copy link
Owner

oleg-shilo commented Feb 4, 2020

Hey Daniel, can you please have a look at your change. I just have released it and it it seems like it does have an unexpected side effect #28.

BTW, it's pleasure to have fellow Australians contributing :)

@AlencarGabriel
Copy link
Contributor

any news?

@oleg-shilo
Copy link
Owner

As you can see Daniel did has not answered.

I do not have capacity to handle this issue right now so if Daniel does not respond in, let's say next 3 days I suggest you downgrade the extension to the prev working version.

And if my capacity will nor improve in a week I will rollback the published version.

@AlencarGabriel
Copy link
Contributor

Ok I understand.

I'll see if I can look at something this week to help, I've already used this View API a lot in another extension that I contribute.

@oleg-shilo
Copy link
Owner

Fantastic. Txs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants