Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change between light and dark version with 'bg' #5

Closed
sindrets opened this issue Oct 22, 2021 · 2 comments
Closed

feat: Change between light and dark version with 'bg' #5

sindrets opened this issue Oct 22, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@sindrets
Copy link

It would be great to be able to switch between the light and the dark version of the color scheme simply by changing the :h 'bg' option.
@olimorris olimorris added the enhancement New feature or request label Oct 22, 2021
olimorris added a commit that referenced this issue Oct 24, 2021
@olimorris
feat ✨ toggle light/dark versions with bg #5
0dc127e
olimorris added a commit that referenced this issue Oct 24, 2021
@olimorris
Merge pull request #8 from olimorris/develop
7d5dbd5 
feat ✨ toggle light/dark versions with bg - addresses #5
@olimorris
Copy link
Owner

olimorris commented Oct 24, 2021 •
edited
Loading

Just merged this now. As long as you don't specify a themeoption in your config, it will respect whatever your background is.

Thanks for your suggestion btw!

@sindrets
Copy link
Author

Brilliant, thanks!

olimorris added a commit that referenced this issue Nov 2, 2021
@olimorris
feat ✨ toggle light/dark versions with bg #5
1c86e22
olimorris added a commit that referenced this issue Feb 15, 2022
@olimorris
feat: ✨ custom highlight groups by filetype (#28)
43bfe7d 
* feat ✨ toggle light/dark versions with bg #5

* chore: update README.md

* fix: speed up load time

* chore: update README.md

* feat: ✨ add alacritty and kitty themes #11

* refactor: rename transparent option to transparency

* refactor: rename highlight_cursorline option to cursorline

* feat: add filetype highlight group customization

* fix: 🔨 #23 plugins always set to true

* chore: speed up buffer navigation

This doesn't make a noticable difference on any of my buffers but is a logical inclusion

* chore: update README.md

* feat: on theme reload apply filetype hlgroups

* fix: urls to onedarkpro in README.md

* chore: fix black color in onedark

* fix: filetype highlights do not work with floating windows

* chore: add disclaimer about telescope highlighting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindrets @olimorris