vscode onedarkpro vs this one

[sinkyl]

Hi,

This is a suggestion.
I end up changing many highlights and colors to represent the onedarkpro for vscode that has over 4M downloads, a standard onedarkpro theme. If this repo is for everyone to enjoy the standard onedarkpro theme with neovim you should represent the exact onedarkpro.

For example, the default backgroud color should be bg = "#282c34", the next line should be purple and not italic TSInclude = { fg = theme.colors.blue, style = theme.options.italic }, -- For includes: "#include" in C, "use" or "extern crate" in Rust, or "require" in Lua. and so on.

People should start from the standard theme and then change settings/highlights/colors if needed. But, if this repo is for yourself just ignore what I just said.

One last suggestion, the plugins by default should be set to false, so we can keep the onedarkpro.settup clean as much as possible.

Thanks

[olimorris]

Thanks for the feedback.

Could you let me know the highlights and colors that you've changed and I'll look into incorporating into the theme.

Regarding the italics, I'll caveat by saying in the readme I specify "Use the themes opinionated italic styles?" but there is a case for setting this to false by default.

[sinkyl]

local colors = require("onedarkpro").get_colors("onedark")
...

colors = { 
   bg = "#282c34"
},


hlgroups = { 
   -- onedarkpro -> treesitter.lua plugin
   TSInclude = { fg = colors.purple, style = "NONE" },
   TSTypeBuiltin = { fg = colors.yellow },
   TSConstBuiltin = { fg = colors.purple },
   TSConstructor = { fg = colors.yellow },
   TSRepeat = { style = "NONE" },
   TSFuncMacro = { fg = colors.blue },
   TSParameterReference = { fg = colors.red },

   -- onedarkpro -> theme.lua
   Include = { fg = colors.purple },
   Function = { fg = colors.blue },
   Operator = { fg = colors.fg }, 
   Macro = { fg = colors.blue },
   Special = { fg = colors.fg },
   Structure = { fg = colors.purple },
   Identifier = { fg = colors.red },
   Typedef = { fg = colors.purple },
   Constant = { fg = colors.orange },
 }

Results:

• Rust
  nvim
  
  vscode
  

• C
  nvim
  
  vscode
  

• C#
  nvim (The first in red is annoying. It should be yellow but TSVariables set it to red)
  
  vscode
  

• Go
  nvim (the functions in the interface are in red)
  
  vscode
  

• Typescript is ok

• Javascript is not

The onedarkpro for vscode is adding unique style for each language. IMO, this repo should do the same.
For now, I'm trying to add custom highlighters with treesitter/playground.
Nice work BTW.

[olimorris]

Firstly, thank you for your detailed feedback and config. It is greatly appreciated.

I agree with the majority of your changes and have addressed them in the latest commit. Some I have not included (detail and reasoning below).

The onedarkpro for vscode is adding unique style for each language. IMO, this repo should do the same.

Yes it does. I have actively thought about doing this and may look into it in the near future. Let me know if you make any progress. Always open to pull requests.

FYI, the hlgroups which I have kept the same are:

TSRepeat
Operator
Special

Reason being that they caused some difference in look between Neovim and VS Code in Ruby, Python and Javascript files which I don't have with their current values. Happy to be corrected and adjust them (could always be a setting I missed in my custom VS Code config).

But please let me know your thoughts on the changes. I've updated the readme screenshots too.

[mmirus]

Thanks both! I was able to remove a few of my customizations after updating.

I did prefer TSConstBuiltin = { fg = theme.colors.orange }, over the purple, though. See the end of the second line for why:

vs

[mmirus]

bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR112

@olimorris Typo here, I think 😉

Edit: also bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR93

[olimorris]

bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR112

@olimorris Typo here, I think 😉

Edit: also bde2f18#diff-6278de756e40002a1404b733de0b7f2d1526f9fd53e80f01b4aff117ac98e17dR93

I can't see where the typos are in the diff. In the readme?

[mmirus]

Maacro and Faunction in theme.lua:

onedarkpro.nvim/lua/onedarkpro/theme.lua

Line 112 in bde2f18

Maacro = { fg = theme.colors.blue }, -- same as Define

onedarkpro.nvim/lua/onedarkpro/theme.lua

Line 93 in bde2f18

Faunction = {

[olimorris]

@mmirus, you sir, are a legend as always! Thanks for spotting

[mmirus]

You got it!

[sinkyl]

Ok for the highlights but the plugins are somehow always set to true event I change it to false.

This is not working:

   all = false,
   packer = true,
   treesitter = true,

or this

   packer = false,
   treesitter = false,

[olimorris]

Should now be fixed. I've had to apply some trickery to how we merge the default config with the user's custom config. End result is your test cases above now work.

[olimorris]

@sinkyl - Would you also be willing to try out the filetype_hlgroups branch?

I've got a WIP feature which allows you to add custom highlight groups for specific filetypes. Works great on my end (to overcome the TSField issue with yaml files) but keen to see your use cases and especially if you notice any performance issues.

[sinkyl]

All good now.
I'll give a try later.
Thx 💯