Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the time display of all day (and non-all-day) events, and handle all_day property #215

Merged
merged 4 commits into from
May 9, 2018

Conversation

osteele
Copy link
Contributor

@osteele osteele commented May 7, 2018

Description

09dbd6f Replace allDay -> all_day in server API

Starts #214

This allows the client to work with old- and new-API servers. Once the client is deployed through to production, and then the API server is deployed through to production and on dev branches, then the API version detection can be backed out.

0e2a206 Fixes #212 all-day events have end time, other events don't

Verified by manual inspection of the snapshot file. Now that this is done, the test should prevent regressions.

Required

Changes must conform to these requirements:

  • yarn test passes. All new and existing tests pass.
  • yarn lint passes. All new code follows the code style of this project.

Aspirational

We don't yet require these, but they are nice to have:

  • New code is covered by new or existing tests.
  • Changed code is covered by new or existing tests.

@osteele
Copy link
Contributor Author

osteele commented May 7, 2018

CI is failing because the tests assume they're running in EDT. This is fixed.

Adding the following to .travis.yml would fix it for Travis, but a developer running in a different TZ could still not run the tests. Also they would stop working when EST starts.

before_install:
- export TZ=America/New_York

@osteele osteele changed the title Osteele/all day events All day events display fix, and handle all_day property May 7, 2018
@osteele
Copy link
Contributor Author

osteele commented May 9, 2018

CI is fixed for this PR.

@osteele osteele changed the title All day events display fix, and handle all_day property Fix the time display of all day (and non-all-day) events, and handle all_day property May 9, 2018
@osteele osteele merged commit 3b06823 into dev May 9, 2018
@osteele osteele deleted the osteele/all_day_events branch May 9, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant