New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make subscription button disappear when subscription is generated #226

Merged

osteele merged 3 commits into master from dev

May 9, 2018

Contributor

osteele commented May 9, 2018

Description

Make subscription button disappear when subscription is generated

Required

Changes must conform to these requirements:

yarn test passes. All new and existing tests pass.
yarn lint passes. All new code follows the code style of this project.

Aspirational

We don't yet require these, but they are nice to have:

New code is covered by new or existing tests.
Changed code is covered by new or existing tests.

HALtheWise and others added 3 commits

May 9, 2018 12:23


          Made subscription button disappear when subscription is generated.

1dcd184

Resolves #222


          Merge pull request #223 from olinlibrary/subscription-ux

48bd924


          Fix a lint error

768b93c

osteele merged commit a433eae into master

coveralls commented May 9, 2018

Pull Request Test Coverage Report for Build 299

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.862%

Totals
Change from base Build 288:	0.0%
Covered Lines:	92
Relevant Lines:	447

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment