Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio/video effects for entire tracks #13

Closed
itsmattkc opened this issue Jan 29, 2018 · 9 comments
Closed

Audio/video effects for entire tracks #13

itsmattkc opened this issue Jan 29, 2018 · 9 comments

Comments

@itsmattkc
Copy link
Contributor

No description provided.

@itsmattkc
Copy link
Contributor Author

later my child

@maingi2
Copy link

maingi2 commented Jul 25, 2018

audio/video effects for E N T I R E S E Q U E N C E ?

@itsmattkc
Copy link
Contributor Author

ENTIRE SEQUENCES

@elsandosgrande
Copy link
Collaborator

Wait, how would it even work for entire sequences?

@frink
Copy link

frink commented Mar 4, 2019

I think this has to do with things like coloration effects or overlays which are both handled differently in Olive...

@unfa
Copy link
Contributor

unfa commented Mar 20, 2019

+1 for effects for tracks
+1 for effects for sequences

This'd allow to have a master audio limiter, which is a really needed thing.

@Simran-B
Copy link
Collaborator

I wonder how this could be integrated the most sensible way...

  1. Right-click a Sequence in the Project panel > Preview in Media Viewer and the Effects tab could then be updated to the Sequence. The user would need to switch to the Effects panel manually though, which wouldn't be very obvious.

    image

  2. Same as above, but with a dedicated entry in the menu to Edit Effects. This would switch to the Effects tab and be thus straightforward.

    image

  3. Integrated into the Properties dialog. Transitions don't make much sense here I guess, and some parameters not either (the entire transformation panel?!). This would make the dialog quite convoluted and introduce the need for a scrollbar.

    image

  4. Tweak the audio meter into something like a muster bus. Not sure how I feel about adding the Add Video Effect button there... but it would require distinct icons for video and audio effects.

    image

  5. Somewhere else?

For effects per track, an obvious solution would be to add a column in front of the timeline:

image

In my mockup there is a title and the button to add an effect to a track, but this could actually be extended a lot:

  • hide/mute track
  • lock track
  • collapse/expand track to save vertical space
  • set color for track to visually group tracks (common in DAWs, not sure if useful in a video editor)

@itsmattkc
Copy link
Contributor Author

This will be addressed in the node rewrite.

@frink
Copy link

frink commented May 5, 2019

Are we going to reopen these issues when we do the restructure? Or what is your thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants