Fixes @a[r=X] & Allows the plugin to work with 1.7-1.17 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now 1.7-1.17 is fully supported!
Changed the Url sending to use Adventure.
GrangerTheDog
changed the title
|
Added some more stuff! Like the ability to use with 1.7-1.17 |
Open
Saving and loading of the RegionExtended has been added
…er_region # Conflicts: # plugin/src/main/java/net/mcjukebox/plugin/bukkit/managers/RegionManager.java # plugin/src/main/java/net/mcjukebox/plugin/bukkit/managers/objects/RegionExtended.java
TehBrian
reviewed
Dec 22, 2021
|
|
||
| public @NonNull BukkitAudiences adventure() { | ||
| if(this.adventure == null) { | ||
| throw new IllegalStateException("Tried to access Adventure when the plugin was disabled!"); |
There was a problem hiding this comment.
nitpick, but the if statement style should match the rest of the project (space after if)
| TextComponent message = Component.text() | ||
| .append(LegacyComponentSerializer.legacy('&').deserialize(langManager.get("user.openClient"))) | ||
| .clickEvent(ClickEvent.openUrl(URL)) | ||
| .hoverEvent(HoverEvent.showText(LegacyComponentSerializer.legacy('&').deserialize(langManager.get("user.openClient")))).build(); |
There was a problem hiding this comment.
.legacy('&') can be replaced with .legacyAmpersand()
| @@ -33,4 +33,5 @@ | |||
| </dependency> | |||
| </dependencies> | |||
|
|
|||
|
|
|||
Volume per region
oliverdunk
added a commit
that referenced
this pull request
Oct 6, 2024
|
Sorry for taking far too long with this one - I've extracted the bug fix into b528fe3. I'm going to close this since I think the rest of the changes are related to the volume work you've done which isn't currently supported by the public client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error that happens when the Location and Player are not in the same world in the isInRange function!
Reported by 4P5#1749 in the Discord channel!
Caused by: java.lang.IllegalArgumentException: Cannot measure distance between world and world_nether