Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #321

Merged
merged 18 commits into from
Jun 18, 2024
Merged

Develop #321

merged 18 commits into from
Jun 18, 2024

Conversation

olucurious
Copy link
Owner

No description provided.

Subhransu Das and others added 11 commits May 12, 2024 11:07
Added v1 endpoints for pyFCm in new v1 package.
0b901df 
Added test for v1 baseapi
Fixed pipeline for test cases
3630f45
Fixed tests
686b69a
@olucurious
Merge pull request #319 from Subhrans/feature-pyfcm-v1
51d7d62 
Added v1 endpoints for pyFCm in new v1 package.
Fixed tests for async
0066c09 
Implemented priority for android
formatted codes with black
- Fixed pipeline - should run on every action for code quality checks
3255946 
- Added black formatting steps to check whether the codes are formatted or not before merge
- Fixed pipeline - should run on every action for code quality checks
67babad 
- Added black formatting steps to check whether the codes are formatted or not before merge
@olucurious
Merge pull request #323 from Subhrans/bugfix-pipeline
bee89b1 
- Fixed pipeline - should run on every action for code quality checks
@olucurious
Merge pull request #322 from Subhrans/bugfix-pyfcm-v1
d2321b3 
Fixed tests for async
- Formatted code
1dd7c25
@olucurious
Merge pull request #324 from Subhrans/bugfix-pyfcm-v1
a36370a 
- Formatted code
@Subhrans
Copy link

Subhrans commented Jun 9, 2024

Hi @olucurious ,
I am waiting for your approval 😃 .
Please check, if all is okay, then we can merge.

Thanks

@Subhrans
Copy link

Hi @olucurious,
We need to deploy these changes before 21st June 2024. Please merge accordingly. If you find any bug I will fix it immediately.
image

Thanks

@Subhrans
Copy link

@olucurious,
Hi, Still i am waiting for your reply on this PR.

@saikreddy
Copy link

yes @olucurious, please review and merge the PR, as the deadline is 20th June for the legacy FCM APIs to get deprecated

@olucurious
Copy link
Owner Author

I'm doing some refactoring, but an update will be pushed today

@Subhrans
Copy link

@olucurious ,
Thanks for the reply.
Ping me if you need anything. I am available.

@jinwoojimmy jinwoojimmy mentioned this pull request Jun 18, 2024
Closed
@saikreddy
Copy link

Hi @olucurious, sorry to bother you, but could you please review and merge the PR at your earliest convenience? We need sufficient time to test it in our dev environments before moving it to production.

@almaz1213
Copy link

almaz1213 commented Jun 18, 2024 •
edited
Loading

... as always on the last day )))
please, drop here some instruction to update via pip.
thanks in advance

1

wkpark
wkpark reviewed Jun 18, 2024
View reviewed changes
pyfcm/__meta__.py Outdated

__version__ = '1.5.2'
__version__ = "1.5.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "1.5.2"
__version__ = "1.5.5"

need to fix version string 1.5.5 or somthing

wkpark
wkpark reviewed Jun 18, 2024
View reviewed changes
setup.py
author_email=meta["__email__"],
description=meta["__summary__"],
long_description=read("README.rst"),
packages=["pyfcm"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packages=["pyfcm"],
packages=["pyfcm", "pyfcm.v1"],

pyfcm.v1 is missing

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wkpark ,
Good catch.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olucurious ,
Do we need this to be mentioned in the packages list?

@olucurious
Copy link
Owner Author

olucurious commented Jun 18, 2024 •
edited
Loading

Hey fellas, some necessary breaking changes are introduced in the new version(https://github.com/olucurious/PyFCM/tree/develop) due to changes and limitations in the v1 API.

Any thoughts before I push to pypi?

ibrahimpl
ibrahimpl reviewed Jun 18, 2024
View reviewed changes
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@olucurious @ibrahimpl
Update CONTRIBUTING.rst
bacdcc3 
Co-authored-by: ibrahimpl <89786754+ibrahimpl@users.noreply.github.com>
@Subhrans
Copy link

Hey fellas, some necessary breaking changes are introduced in the new version(https://github.com/olucurious/PyFCM/tree/develop) due to changes and limitations in the v1 API.

Any thoughts before I push to pypi?

No, everything is fine, Did you check in your machine? If everything is working same, then I am happy to see this to be merged 🙂

@olucurious olucurious merged commit 33055f0 into master Jun 18, 2024
2 checks passed
@olucurious
Copy link
Owner Author

Thank you so much @Subhrans for kicking off the migration with your PR contribution 👏🏾👏🏾

@jhonsoto-aflore
Copy link

@olucurious and @Subhrans TypeError: send_async_request() got an unexpected keyword argument 'payloads'

@wkpark
Copy link

wkpark commented Jun 19, 2024

See also #308

@olucurious
Copy link
Owner Author

Fixed in 2.0.2

@almaz1213
Copy link

almaz1213 commented Jun 19, 2024 •
edited
Loading

we have error !

steps:

  1. updated pyfcm to 2.0.2
  2. generated new fcmServiceAccKey.json in the Firebase console
  3. our android app got new fcm token for a user

test code on the server side:

from pyfcm import FCMNotification

fcm = FCMNotification(service_account_file=<absolute path to>fcmServiceAccKey.json', project_id='iolmsg-filestore')

res = fcm.notify(<user token from step 3>, 'title', 'text')

print(res)

result:
1

use to use method .notify_single_device but now FCMNotification has no this method

@olucurious
Copy link
Owner Author

Can you manually test from the Firebase console?

@Subhrans
Copy link

Hi @olucurious,
Why I can't see myself on the contributor list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimpl ibrahimpl ibrahimpl left review comments

@Subhrans Subhrans Subhrans left review comments

@wkpark wkpark wkpark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@olucurious @Subhrans @saikreddy @almaz1213 @jhonsoto-aflore @wkpark @ibrahimpl