Make function names terse. Make functions private. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename all the generator functions. Use the prefix "gen_" instead of "generate_". For example, `generate_date` is now `gen_date`. Make helper functions private. Rename `codify` to `_make_unicode` and `is_positive_int` to `_is_positive_int`. Silence some pylint and flake8 warnings, either by fixing the relevant error (e.g. use better names for unused variables) or silencing the relevant error (e.g. the use of the Python 2 keyword "unicode").
|
ACK |
omaciel
added a commit
that referenced
this pull request
Sep 22, 2014
Make function names terse. Make functions private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all the generator functions. Use the prefix "gen_" instead of
"generate_". For example,
generate_dateis nowgen_date.Make helper functions private. Rename
codifyto_make_unicodeandis_positive_intto_is_positive_int.Silence some pylint and flake8 warnings, either by fixing the relevant error
(e.g. use better names for unused variables) or silencing the relevant error
(e.g. the use of the Python 2 keyword "unicode").