Implement backward compatiblility #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a class `FauxFactory`. Provide it with a set of public class methods and make them call the equivalent new-style functions. Also provide a `codify` function that wraps the new `_make_unicode` function. Provide a basic set of sanity tests for these wrappers. Do not alter the module-wide variable `__all__`. This prevents the compatiblity code from showing up in Sphinx-generated documentation or being imported by `from fauxfactory import *`.
|
Still no Internet at home but thank you for doing this! I actually started playing with the compatibility class by creating a dumb class, then importing all methods from the module itself and adding them to the class (setattr with classmethod(method_name)) if the function name started with |
|
ACK |
omaciel
added a commit
that referenced
this pull request
Sep 22, 2014
Implement backward compatiblility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a class
FauxFactory. Provide it with a set of public class methods andmake them call the equivalent new-style functions. Also provide a
codifyfunction that wraps the new
_make_unicodefunction.Provide a basic set of sanity tests for these wrappers.
Do not alter the module-wide variable
__all__. This prevents the compatiblitycode from showing up in Sphinx-generated documentation or being imported by
from fauxfactory import *.