Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation player #303

Merged
merged 2 commits into from May 1, 2019

Conversation

@glmdgrielson
Copy link

commented Jan 20, 2019

This addresses issue #110. Yay for adding annotations back!

This should do until the archive system gets revamped.

@omarroth

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2019

Great!

I'll plan on adding an updated version of videojs-youtube-annotations.js before merging, since there's quite a few features missing that are included in the extension it's based on.

The /api/v1/annotations/:id is temporary and will also change once everything has been uploaded to the Internet Archive.

https://dev.invidio.us is now pulling from this branch, so if annotations for a video are available from the temporary API, you should be able to view them.

@glmdgrielson

This comment has been minimized.

Copy link
Author

commented Jan 21, 2019

So the video issue gas been resolved? What about the 4.3 one?

@omarroth

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2019

I expect that will be fixed in afrmtbl/annotationlib.

@omarroth omarroth force-pushed the glmdgrielson:annotations branch 3 times, most recently from ee87467 to 7deaf29 Jan 24, 2019
@glmdgrielson

This comment has been minimized.

Copy link
Author

commented Jan 29, 2019

Why aren't we using the <%= video.id %> here?

@omarroth

This comment has been minimized.

Copy link
Owner

commented Jan 30, 2019

<%= video.id %> refers to the current video. For annotations, we want to find the video that's being linked, so we use the video ID included in the search parameters.

@omarroth omarroth force-pushed the glmdgrielson:annotations branch 4 times, most recently from be686da to cf9c9c7 Jan 31, 2019
@AgentGrady

This comment has been minimized.

Copy link

commented Feb 5, 2019

Several videos that had working annotations on invidious just a few days ago have suddenly stopped working. Why is this?

@omarroth

This comment has been minimized.

Copy link
Owner

commented Feb 5, 2019

Mind posting the output of the console or linking to an example?

@omarroth omarroth force-pushed the glmdgrielson:annotations branch from 826b0e8 to ff2fd6f Feb 10, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch from ff2fd6f to a260310 Feb 11, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch 5 times, most recently from 41bc926 to c413004 Feb 12, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch 5 times, most recently from 6dcf374 to 99fe143 Feb 19, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch 10 times, most recently from 1f8821b to 81355a3 Apr 11, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch 11 times, most recently from 0a275c1 to 0ff30e5 Apr 18, 2019
@omarroth omarroth force-pushed the glmdgrielson:annotations branch 2 times, most recently from 002cd3d to 68c9878 Apr 28, 2019
glmdgrielson and others added 2 commits Jan 20, 2019
This addresses issue #110 from master. Yay for adding annotations back!
@omarroth omarroth force-pushed the glmdgrielson:annotations branch from 68c9878 to 56fe3ed May 1, 2019
@omarroth omarroth merged commit ba02be0 into omarroth:master May 1, 2019
@omarroth omarroth referenced this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.