Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logo #11

Merged
merged 1 commit into from
Nov 18, 2020
Merged

fix logo #11

merged 1 commit into from
Nov 18, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 16, 2020

this should hopefully fix things

@joshmoore
Copy link
Member

Which tool produced each version?

@jburel
Copy link
Member Author

jburel commented Nov 16, 2020

The original one was directly copied from https://raw.githubusercontent.com/jupyterhub/binderhub/master/binderhub/static/logo.svg
I re-opened it in inkscape due to characters errors

@sbesson
Copy link
Member

sbesson commented Nov 16, 2020

Looks like the primary issue was a missing double quote:

sbesson@ls30630:.github (master) $ git show --oneline
d0e0248 (HEAD -> master, origin/master) Merge pull request #10 from jburel/binder_badge

sbesson@ls30630:.github (master) $ wget https://raw.githubusercontent.com/jupyterhub/binderhub/master/binderhub/static/logo.svg
--2020-11-16 20:59:07--  https://raw.githubusercontent.com/jupyterhub/binderhub/master/binderhub/static/logo.svg
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 199.232.52.133
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|199.232.52.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3007 (2.9K) [image/svg+xml]
Saving to: ‘logo.svg’

logo.svg            100%[===================>]   2.94K  --.-KB/s    in 0s      

2020-11-16 20:59:08 (11.4 MB/s) - ‘logo.svg’ saved [3007/3007]
sbesson@ls30630:.github (master) $ diff -w logo.svg workflow-templates/binder.svg 
2c2
< <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
---
> <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd>

@sbesson
Copy link
Member

sbesson commented Nov 18, 2020

Thanks. Looks good now.
The main downside is that it is the rectangular logo with the name but I assume there is no SVG version of the square binder logo?

@jburel
Copy link
Member Author

jburel commented Nov 18, 2020

There is none in the repo

@sbesson
Copy link
Member

sbesson commented Nov 18, 2020

Understood. LGTM

@sbesson sbesson merged commit 24214f6 into ome:master Nov 18, 2020
@sbesson
Copy link
Member

sbesson commented Nov 18, 2020

Screenshot 2020-11-18 at 09 13 27

@jburel jburel deleted the fix_badge branch March 22, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants