-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle: fix creation of wrapper #18
Conversation
@jburel i have not seen the error but have you tried moving the action checking out the repository after the ones setting up the Java environment including Gradle? |
you will still need to move |
The error is the following
cf. https://github.com/jburel/omero-blitz/runs/1525813901 This is an error that occurs with gradle 6.x. That error also means that the |
I did some test using my current PR of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks for the error I was able to reproduce locally. So the issue is not about building than simply evaluating the root project which is indeed incompatible with Gradle 6.x for omero-blitz
. It's unfortunate there is not built-in way to install the specified version before evaluating the project.
Looking at ome/omero-blitz#113, the omero-blitz
is already itself an extension of this template as it requires extra dependencies installed. Apart from omero-blitz
, how many repositories require a version of Gradle that differs from the default?
- name: Wrap without version | ||
run: gradle wrapper | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the default installed version of Gradle is used, is this custom installation necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is otherwise we cannot use gradlew
in the following step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I failed to find a failing build in these circumstances as it looks like all the omero-*
workflows are overriding gradle_version
.
omero-blitz is the only one so far, so we could keep the template as it is |
Understood, if In case it's useful, while reviewing |
It is still generic with the change proposed in this PR. It makes sure it works. |
That strategy no longer works with Gradle7! |
When creating the wrapper in the current directory, gradle already tries to build with the version currently installed (5.6.1).
I only discovered the problem when working on
omero-blitz
.When this is merged, we can update the
gradle.yml
file in the various repositories or wait for the publication stepsto be included.
Tested changes on all ubuntu, windows and mac: https://github.com/jburel/omero-model/actions/runs/411333070