Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new template workflow for OMERO plugins #5

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 2, 2020

  • Create template workflow setting up omero-test-infra and running a stage
  • Add minimal JSON description including the OMERO icon

This workflow has been tested using the following four stages:

Once approved, the proposal would be to roll it out against all submodules of https://github.com/ome/omero-plugins/

/cc @jburel @joshmoore @manics

- Create template workflow setting up omero-test-infra and running a stage
- Add minimal JSON description including the OMERO icon
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

The only thing that occurred to me while reading this and it would need changing on the omero-test-infra side is that travis_fold no longer functions. But see:

https://github.community/t/has-github-action-somthing-like-travis-fold/16841

though it looks like it still needs some work from their side.

Oops, thought 2: An option we may want to consider is having the target of the omero-test-infra checkout be either an org or a repo variable (can one define both?!) so that if things start breaking on master we can pin to a given version.

@sbesson
Copy link
Member Author

sbesson commented Nov 3, 2020

Re folding, probably a mid-term question will be whether omero-test-infra should be converted into or wrapped by a GitHub action and decompose each stage into steps.

Re target branch, I did not find a way to define org-level environment variables, only secrets. Depending on the above, an action might also be an option to pin to a given tag. Immediately, would it be worth adding ref: '' to the checkout action so that it can be overriden?

@joshmoore
Copy link
Member

I did not find a way to define org-level environment variables, only secrets.

Guess it wouldn't be too wrong to use an org secret.

would it be worth adding ref: '' to the checkout action so that it can be overriden?

No overly strong feeling, especially if it causes pain. The biggest cost to not doing it now is that repos that use the template will need to be updated.

@sbesson
Copy link
Member Author

sbesson commented Nov 3, 2020

See 04de2fc. Without a defined secret, this will checkout the default branch - see https://github.com/sbesson/omero-scripts/runs/1346856057.

@joshmoore
Copy link
Member

Nice. So it defaults to empty? And then repo secrets take preference over org secrets, right? Sounds like a good failsafe.

@sbesson
Copy link
Member Author

sbesson commented Nov 3, 2020

Nice. So it defaults to empty?

That's what I assume but I failed to find the authoritative reference confirming this statement

And then repo secrets take preference over org secrets, right?

Yes, as per the reference page, the precedence seems to be repo-level secret first then org-level secret.

@sbesson
Copy link
Member Author

sbesson commented Nov 3, 2020

As per the discussion above, merging and I will have a go at fixing https://github.com/ome/omero-plugins/ and its submodules tomorrow

@sbesson sbesson merged commit c8e7d8e into ome:master Nov 3, 2020
@sbesson sbesson deleted the omero_template branch November 3, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants