-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new template workflow for OMERO plugins #5
Conversation
- Create template workflow setting up omero-test-infra and running a stage - Add minimal JSON description including the OMERO icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
The only thing that occurred to me while reading this and it would need changing on the omero-test-infra side is that travis_fold
no longer functions. But see:
https://github.community/t/has-github-action-somthing-like-travis-fold/16841
though it looks like it still needs some work from their side.
Oops, thought 2: An option we may want to consider is having the target of the omero-test-infra checkout be either an org or a repo variable (can one define both?!) so that if things start breaking on master we can pin to a given version.
Re folding, probably a mid-term question will be whether Re target branch, I did not find a way to define org-level environment variables, only secrets. Depending on the above, an action might also be an option to pin to a given tag. Immediately, would it be worth adding |
Guess it wouldn't be too wrong to use an org secret.
No overly strong feeling, especially if it causes pain. The biggest cost to not doing it now is that repos that use the template will need to be updated. |
See 04de2fc. Without a defined secret, this will checkout the default branch - see https://github.com/sbesson/omero-scripts/runs/1346856057. |
Nice. So it defaults to empty? And then repo secrets take preference over org secrets, right? Sounds like a good failsafe. |
That's what I assume but I failed to find the authoritative reference confirming this statement
Yes, as per the reference page, the precedence seems to be repo-level secret first then org-level secret. |
As per the discussion above, merging and I will have a go at fixing https://github.com/ome/omero-plugins/ and its submodules tomorrow |
This workflow has been tested using the following four stages:
app
https://github.com/sbesson/omero-weberror/actions/runs/336640108cli
https://github.com/sbesson/omero-metadata/actions/runs/336624854lib
https://github.com/sbesson/minimal-omero-client/runs/1344293996scripts
https://github.com/sbesson/omero-scripts/actions/runs/336633466Once approved, the proposal would be to roll it out against all submodules of https://github.com/ome/omero-plugins/
/cc @jburel @joshmoore @manics