-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add file to build doc in /docs #9
Conversation
Still need a bit of work!! |
using secrets did not work! |
You mean to push to another repository? |
no this is only taking care of building the doc; in that case the directory specified is where the doc is located. Most repositories have the sphinx documentation under |
I have tested this template against ome-documentation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments but certainly nothing that needs addressing here.
@joshmoore I managed to simplify the way the action was setting the directory. It has to be done in 2 steps but it reduces the overall complexity |
hold off on that one, still investigating to see if we can do things better |
I looked at some sphinx actions, it works fine for repo like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments but generally looks good. 👍
with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last option is a good compromise between sensible default commands and flexibility.
merging so I can roll it out across repositories |
Add file to build the Sphinx documentation in the folder
/docs