Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #62

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update README.md #62

merged 1 commit into from
Dec 8, 2023

Conversation

joshmoore
Copy link
Member

Fix #60

  • remove previous custom jar requirements
  • add current installation instructions
  • review TODOs

cc: @dgault

@joshmoore
Update README.md
cfdfa2e 
Fix #60

- [x] remove previous custom jar requirements
- [x] add current installation instructions
- [ ] review TODOs

cc: @dgault
sbesson
sbesson reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this update might also be considered for the upcoming release as the content of the readme is very outdated

@joshmoore
Copy link
Member Author

👍

dgault
dgault approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good. I will further update the readme in a follow up PR to update the TODO list and document the new options

@dgault dgault merged commit 82ce2d9 into main Dec 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbesson sbesson sbesson left review comments

@dgault dgault dgault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct README regarding jzarr library
3 participants
@joshmoore @sbesson @dgault