-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dev.zarr:jzarr to 0.4.2 #66
Conversation
Thanks, @sbesson. If the official unidata repo works, I don't see why we wouldn't use it. The only reason I can think of is that this cloud repo was "the" place to get snapshots. |
The tilaa.cloud based server introduced in bcdev@020f964 no longer has a valid certificate leading to build errors. This PR migrates to the official Unidata repository as in ome/ZarrReader#66
In trying to release zarr-developers/jzarr#15 today as 0.4.1, I ran into the same issue and therefore I'm now releasing zarr-developers/jzarr#17 as 0.4.2 😄 |
Should the change here be replaced by a bump to |
It's now up on https://central.sonatype.com/artifact/dev.zarr/jzarr/ if you want to try. I thought that it was necessary to list in each repo, but perhaps something changed. |
Looks like bumping to
I recalled something similar about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Downstream consumers of this reader have been failing to build it over the last few days - see https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-image/372/console or https://github.com/ome/openmicroscopy/actions/runs/6666558502/job/18118363098 with
The source of the issue is the expiration of the certificate of the repository declared in https://github.com/zarr-developers/jzarr/blob/d4f85aa20816a1a0137ad3fa5a5a8513fd790c6e/pom.xml#L155-L167 and used to retrieve the
netcdf
dependency ofjzarr
.This is not specific to
zarr.dev:jzarr
as the repository was introduced in the original repository in bcdev/jzarr@020f964.It's unclear why this repository has been chosen and whether the certificates will be fixed. As a stopgap, this commit declares the standard Unidata repository used across the rest of Bio-Formats in this consumer repository. This should allow the builds to use this repository to fetch the
netcdf
dependency.If the problem persists, the same change could be opened against https://github.com/zarr-developers/jzarr /cc @joshmoore