Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor omero-server role (breaking changes) #8

Merged
merged 41 commits into from
Apr 19, 2017
Merged

Conversation

manics
Copy link
Member

@manics manics commented Mar 24, 2017

This implements ome/design#73 in conjunction with

It also implements a variant of ome/design#70 using a systemd ExecStartPre script to reinitialise the omero configuration from a directory of *.omero files.

Major changes from version 1.* of this role are outlined in CHANGES.md.

@manics manics changed the title Refactored omero-server role (breaking changes, version 2.0.0) Refactor omero-server role (breaking changes) Mar 24, 2017
@joshmoore
Copy link
Member

The changes document reads quite well, but I haven't been able to review all of them individually (in terms of naming etc). To some degree, we almost need a period of low-version numbers (omero-server2:0.1.0) to work through the API here before saying that this is stable. Anyone have suggestions on how to manage that?

@manics
Copy link
Member Author

manics commented Mar 31, 2017

@sbesson we need some advice on naming versions 😄

@sbesson
Copy link
Member

sbesson commented Apr 3, 2017

@manics :) An alternative to #8 (comment) might be to maintain the same role name but express the fact we are working towards an API-breaking 2.0.0 using explicit semver tags like 2.0.0-m1 or 2.0.0-alpha1. Is the latter supported by Ansible Galaxy as I could not find the official doc on their supported versioning scheme? Also what happens if a Galaxy requirements file does not contain any version for a tagged role - does it default to the HEAD of master, the last role tag or does it fail?

@manics
Copy link
Member Author

manics commented Apr 3, 2017

I don't know what the behaviour of tags is. If we're happy to test without tagged versions we could create a separate develop branch, and depend on the git-hash?

@manics
Copy link
Member Author

manics commented Apr 5, 2017

Last four commits:

  • Change the system user to omero-server (requested on an issue in a private repo)
  • Add some travis/ansible/omego/omero workarounds.

@manics
Copy link
Member Author

manics commented Apr 5, 2017

Last commit uses https://pypi.python.org/pypi/ome-ansible-molecule-dependencies/ for bundling dependencies

@sbesson
Copy link
Member

sbesson commented Apr 19, 2017

As discussed with @joshmoore and @manics, assuming there is no additional planned breaking change, I would vote for merging this into master, tag it 2.0.0-m1 (or maybe 2.0.0-rc1), test it in the various playbooks where this roles is exposed and then release 2.0.0 post testing. If needed, we can derive a stable branch for 1.x.y releases.

@joshmoore
Copy link
Member

👍

@joshmoore joshmoore merged commit 4ae7307 into ome:master Apr 19, 2017
@manics manics deleted the devel branch April 19, 2017 14:31
@sbesson sbesson added this to the 2.0.0 milestone Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants