Rewrite playbooks and vars to work with new omero-* roles (IDR-0.3.5) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in the IDR openmicroscopy source tree ome/openmicroscopy#4989
|
Is this what was deployed as test35? |
|
After a "yes" in slack: looking at the server, the results of these changes seems quite sane. There are a few questions in terms of naming, etc. to go through, but the basic goal of a tidied-up installation seems to be achieved. |
|
All boxes are checked. This should be good for a requirements bump. |
|
Bumped, waiting for travis. |
|
Merging with travis green. Will handle final version bumps in gh-16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly involves renaming variables or changing their type (e.g. list/dict). In addition I've removed
IDR-OMERO-52-omero.j2and put those variables intogroup_vars/omero-hosts. Many of these variables are of json type, and the new omero roles allow autoconversion of YAML lists/dicts into json config strings. This should be easier to maintain.--depends-on (may require a tag)
Other than that there should be no difference from the previous version. OMERO.server and OMERO.web are still on the same host, future PRs may involve changing this.