Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install CLI duplicate plugin for running OMERO tests. #174

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Sep 16, 2020

See ome/omero-py#249 (comment) for background.

@@ -93,6 +94,11 @@ for x in *.tar.gz; do
pip install -U $x
done

# Cause CLI plugin tests to be run against the relevant version.
for x in omero-cli-duplicate; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this easily extensible and looping over the installation of CLI plugins with associated integration tests in ome/openmicroscopy makes a lot of sense.

Has this change been tested in a daily CI execution or is it worth re-running merge-ci OMERO-test-integration to ensure the logic does what we want?

Copy link
Member Author

@mtbc mtbc Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been tested in a daily CI execution.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altered latest, merge configs by hand, they seem to be happy so far.

</project>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Jenkins does revert these so this will create an unnecessary diff in running devspaces. Can this change be removed?

@sbesson sbesson merged commit 86964cb into ome:master Sep 17, 2020
@sbesson
Copy link
Member

sbesson commented Sep 17, 2020

Tagged as 0.15.6, merged the tag into merge-ci and latest-ci and reloaded Jenkins from the configuration on disk.

@mtbc mtbc deleted the install-cli-duplicate branch September 17, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants