Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMERO documentation job #72

Merged
merged 5 commits into from
Sep 20, 2017
Merged

OMERO documentation job #72

merged 5 commits into from
Sep 20, 2017

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 12, 2017

See https://trello.com/c/ccx2knE7/141-check-whether-sphinx-can-be-upgraded-for-all-docs-jobs

Prior to upgrading the Sphinx dependency on our production CI, this PR ports recent additions allowing to:

To test this PR, review https://minke.openmicroscopy.org:32833/job/OMERO-docs/

This job can be used to review documentation PRs alongside the code PR provided
that the same development branch exists on the documentation repository.
@joshmoore
Copy link
Member

joshmoore commented Sep 19, 2017

Generally, 👍

@sbesson
Copy link
Member Author

sbesson commented Sep 19, 2017

Re push job, we could easily create an extra job e.g. OMERO-docs-push to create a clear integration branch. Happy to add it to this PR if you think it would be valuable immediately.

Re single landing page, I had the same feeling when working through #74 (comment). Might need some more thoughts - I would assume that's something that would need to be generated post deployment to retrieve the dynamic ports.

@sbesson sbesson added this to the 0.6.0 milestone Sep 19, 2017
@joshmoore
Copy link
Member

I don't know if there's a pressing need. It might be easier for us to move to the single push job rather than having one per new repo added here. Updated to also be RFE.

@sbesson
Copy link
Member Author

sbesson commented Sep 20, 2017

Makes sense. Shall we merge as it is then and capture the landing page RFE as an issue?

@joshmoore joshmoore mentioned this pull request Sep 20, 2017
@joshmoore
Copy link
Member

@joshmoore joshmoore merged commit 572acc5 into ome:master Sep 20, 2017
@sbesson sbesson deleted the docs branch September 20, 2017 08:33
@jburel jburel mentioned this pull request Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants