This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
cleanup devspace #149
Merged
cleanup devspace #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#1040. See the console output for more details.
|
|
Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#1041. See the console output for more details.
|
|
Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#1042. See the console output for more details.
|
|
Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#1043. See the console output for more details.
|
|
Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#1044. See the console output for more details.
|
|
using vars and ome/devspace#52: deployed on 10.0.51.106 |
atarkowska
commented
Nov 2, 2016
| # devspace branch | ||
| version: "0.3.2" | ||
| devspace_git_repo_version: "0.3.3" |
|
|
|
DO NOT USE ansible 2.2 looks like many things has changed in ansible 2.2 Need to look at that closer |
It's deprecated syntax that has obviously been dropped in 2.2: https://github.com/openmicroscopy/infrastructure/blob/master/ansible/roles/docker/tasks/main.yml#L69 |
sbesson
reviewed
Nov 3, 2016
| replace: '\1<jenkinsUrl>https://{{ devspace_openstack_ip }}:8443</jenkinsUrl>' | ||
| with_items: | ||
| - jenkins.model.JenkinsLocationConfiguration.xml | ||
| when: devspace_openstack_ip|length>0 |
There was a problem hiding this comment.
Note this forces devspace_openstack_ip to be defined. Otherwise, the playbook fails with
TASK [devspace : fix jenkinsUrl] ***********************************************
fatal: [seb-devspace]: FAILED! => {"failed": true, "msg": "The conditional check 'devspace_openstack_ip|length>0' failed. The error was: Unexpected templating type error occurred on ({% if devspace_openstack_ip|length>0 %} True {% else %} False {% endif %}): object of type 'NoneType' has no len()\n\nThe error appears to have been in '/opt/ome/management_tools/infrastructure/ansible/roles/devspace/tasks/devspace-install.yml': line 181, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: fix jenkinsUrl\n ^ here\n"}
Is there a way to have the conditional being more robust or define a default IP like 0.0.0.0?
There was a problem hiding this comment.
no ,you can't, that is your jenkins host and jenkins must have that set to the real value. Otherwise testNG results won't show up
There was a problem hiding this comment.
I am sure default(inventory_hostname) would solve the problem but unfortunately I dont know how to use it
|
#149 (comment) is not a blocker as the behavior was already there but it might be interesting to use the dynamic inventory to retrieve the IP for simplification in the future. Otherwise, I was able to provision, deploy and run the devspace from the tip of this branch. Merging. |
|
thx for testing |
manics
pushed a commit
to manics-archive/ome-infrastructure
that referenced
this pull request
Nov 24, 2016
cleanup devspace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renams vars and fixed jenkins url to match ip (that value is used by testng)
Test:
with ome/devspace#52
default: