ome-dundeeomero backup script Fix: can't use sudo from /etc/cron

[kennethgillen]

An update to address the fact that the nightly backup was failing, though testing at the shell was successful.

Check mode against ome-dundeeomero: ansible_run-backup-script-CHECK-ome-dundeeomero_20170704-120625Z.txt

Live run against ome-dundeeomero: ansible_run-backup-script-UPDATE-ome-dundeeomero_20170704-120909Z.txt

Without this PR

[root@ome-dundeeomero cron.daily]# run-parts  /etc/cron.daily/ -v
[root@ome-dundeeomero cron.daily]# du -sh /backups/*
64K    /backups/nightly-pg_dump_omero.dir

With this PR

[root@ome-dundeeomero cron.daily]# run-parts  /etc/cron.daily/ -v
[root@ome-dundeeomero cron.daily]# du -sh /backups/*
1.7G    /backups/nightly-pg_dump_omero.dir

[joshmoore]

Oh, I'm glad this got caught earlier rather than later!

[kennethgillen]

Yep, agree with those sentiments for sure. I'd dallied adding the backup file size/age monitoring - that's still not in place, I prioritised omero-user-sessions (unique users and total sessions), but on the server upgrades running manual dumps I noticed the du was off.

[kennethgillen]

Can confirm:

[root@ome-dundeeomero ~]# date && du -sh /backups/*
Wed  5 Jul 09:35:50 BST 2017
1.7G    /backups/nightly-pg_dump_omero.dir

[manics]

Code looks fine, can't actually see it in action though.

There's a mysql-backup role: https://github.com/openmicroscopy/ansible-role-mysql-backup
If you create something similar for postgres it'll be easier to deploy on other servers.

[kennethgillen]

@manics - if you're happy with #279 (comment) showing it works, care to merge, or 👍 for merge?

[joshmoore]

cF. https://github.com/openmicroscopy/ansible-role-mysql-backup/blob/master/templates/etc-crond-mysql-backup.j2

Agreed that that looks like a good solution, but additionally 👍 for this being fixed and getting it in ASAP.