-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
- Use temporary base image (with OME Files 0.3.0) - Install required JDK7 for JACE bindings and update JAVA_HOME - Build JACE bindings and add BF_JACE_HOME - Update LD_LIBRARY_PATH for runtime benchmarking
@rleigh-codelibre with the last set of commits, I can build the various components but I encounter failures at runtime of type
Probable something related to the environment. Will investigate tomorrow unless you have some ideas. |
@sbesson You do need to copy the |
With the latest commits, I can successfully run the JACE tests in the |
3e9bb6a
to
c59b8fd
Compare
Last commit includes an update of the statistics notebook with the latest results of the Linux/Windows builds using a recent version of the development OME Files. A few notes:
|
@@ -64,7 +64,7 @@ find_package(OMECompat 5.2.0 REQUIRED) | |||
find_package(OMECommon 5.2.0 REQUIRED) | |||
find_package(OMEXML 5.2.0 REQUIRED) | |||
find_package(OMEFiles 0.2.3 REQUIRED) | |||
find_package(BioFormatsJACE 5.2.4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we need to revert this to get the correct header versioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue was related to the JACE discovery and the CMAKE_PATH_PREFIX
variable. After removing the sed
workaround, I was able to rebuild everything and execute the JACE scripts.
|
||
WORKDIR /build2 | ||
COPY cmake/JACEPrerequisites.cmake /git/bio-formats-jace/target/cppwrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs renaming as well; the target is /git/bio-formats-jace/target/cppwrap/Prerequisites.cmake
?
Mostly looks fine I think; a couple of points noted. |
Discussed with @rleigh-codelibre. A couple of issues noted:
|
Follow-up of #5, this PR updates the Dockerfile in order to be able to build and execute the JACE bindings in the Ubuntu 16.04 environment.
A couple of changes are still in progress:
javaTools.cpp
to add the JAR folder to the CLASSPATH and detect the logging configuration file (could be replaced by using another signature ofcreateJVM
with extra classpath)