Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8, 3.9 #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

As per SPEC 0, don't need to support Python 3.8 or 3.9 any more.

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (b5f8506) to head (7b43985).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   85.82%   85.76%   -0.07%     
==========================================
  Files          13       13              
  Lines        1538     1531       -7     
==========================================
- Hits         1320     1313       -7     
  Misses        218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshmoore
Copy link
Member

Thanks, @dstansby. I've recently heard of folks having issues on various platforms so let's see if any of that surfaces here. If not, I can definitely see getting this into the next largish bump.

@will-moore
Copy link
Member

I was having issues getting Ice bindings installed on python 3.10 (our docs state that only python 3.9 was supported). In the end we found a work-around but for users who have working python 3.9 environments it could cause inconvenience to drop python 3.9 support here before we need to.
Happy to drop 3.8 support, but dropping 3.9 support feels a little early (unless supporting it is a burden to us that we are keen to drop?)

@dstansby
Copy link
Contributor Author

The motivation here was zarr follows SPEC 0, so won't (in theory) be supporting Python 3.8/3.9 now anyway, so it makes sense to mirror that here? Happy to change this to just drop 3.8 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants