Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #381

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Drop support for Python 3.8 #381

merged 1 commit into from
Jul 16, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 26, 2024

As per SPEC 0, don't need to support Python 3.8 or 3.9 any more. As per a comment below, I've only dropped support for 3.8 here.

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (b5f8506) to head (2e44a8e).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   85.82%   85.70%   -0.13%     
==========================================
  Files          13       13              
  Lines        1538     1539       +1     
==========================================
- Hits         1320     1319       -1     
- Misses        218      220       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshmoore
Copy link
Member

Thanks, @dstansby. I've recently heard of folks having issues on various platforms so let's see if any of that surfaces here. If not, I can definitely see getting this into the next largish bump.

@will-moore
Copy link
Member

I was having issues getting Ice bindings installed on python 3.10 (our docs state that only python 3.9 was supported). In the end we found a work-around but for users who have working python 3.9 environments it could cause inconvenience to drop python 3.9 support here before we need to.
Happy to drop 3.8 support, but dropping 3.9 support feels a little early (unless supporting it is a burden to us that we are keen to drop?)

@dstansby
Copy link
Contributor Author

The motivation here was zarr follows SPEC 0, so won't (in theory) be supporting Python 3.8/3.9 now anyway, so it makes sense to mirror that here? Happy to change this to just drop 3.8 though.

@dstansby
Copy link
Contributor Author

👍 updated to just drop support for 3.8

@dstansby dstansby changed the title Drop support for Python 3.8, 3.9 Drop support for Python 3.8 Jul 16, 2024
@joshmoore
Copy link
Member

Thanks again, @dstansby. Let's get this in and then we can always iterate from there.

@joshmoore joshmoore merged commit 610c396 into ome:master Jul 16, 2024
17 checks passed
@dstansby dstansby deleted the python-vers branch July 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants