Cross-platform path handling #47
Conversation
Removes the `zarr_path` variable from BaseZarrLocation, using a pathlib.Path field in LocalZarrLocation and a URL string in RemoteZarrLocation to properly handle the creation of subpaths across multiple platforms. In general, use of os.path and especially os.path.join should be avoided in favor of delegating to methods on the zarr location objects.
|
Whew. Finally. So a summary of steps taken and lessons learned to get the build passing:
|
not sure if it will be useful to you... but I have a branch of napari working with GH actions on all platforms (there may of course be other OMERO specific stuff that still need to be figured out): https://github.com/tlambert03/napari/blob/feature/github-tests/.github/workflows/tests.yml |
|
Thanks, @tlambert03. I'll review the diff and see if I can get the Qt working. 👍 |
| GIT_TRACE_PACKET: 1 | ||
| run: > | ||
| git clone --depth 1 git://github.com/vtkiorg/gl-ci-helpers.git || | ||
| git clone --depth 1 git://github.com/vtkiorg/gl-ci-helpers.git |
There was a problem hiding this comment.
It makes sense that these two lines clone the same thing right?
There was a problem hiding this comment.
Yes, the || is the important bit. GHA doesn't currently have "retry" functionality.
There was a problem hiding this comment.
I have close to little experience with pathlib but from a quick reading, it looks like it fulfills the Windows/Unix path support and has the benefit of being a core Python library.
Tests are passing, the code rewriting looks generally sensible although I haven't looked at the details.
A side question is whether we would foresee switching to pathlib in omero-py as a replacement for the path.py fork?
I could definitely see that. Happy for this to be something of a test run. |
Removes the
zarr_pathvariable from BaseZarrLocation, using apathlib.Path field in LocalZarrLocation and a URL string in
RemoteZarrLocation to properly handle the creation of subpaths across
multiple platforms. In general, use of os.path and especially
os.path.join should be avoided in favor of delegating to methods on the
zarr location objects.