-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifacts fix #101
Artifacts fix #101
Conversation
This will break the IDR which uses a custom downloads page: https://github.com/IDR/deployment/blob/master/ansible/group_vars/omero-hosts.yml#L12 Easy to fix (we can just add an extra |
works as expected
|
how about if |
Thanks both. As pointed out by Travis, unit tests would need to be updated anyways to reflect the new changes. But it's good to hear about other use cases. Agreed with @manics that the library is currently working around the fact our downloads pages lack an official layout. Considering turning this into an issue first to discuss the various options. |
@manics @joshmoore @jburel: the last commits should fix all failing unit and integration tests, add the missing changelog for 0.5.0 and add documentation for this breaking bug fix both in the changelog and the help displayed by As mentioned elsewhere, any consumer of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor points.
I don't think the additional complexity of --legacy_downloads
is worthwhile.
omego/artifacts.py
Outdated
@@ -431,7 +431,8 @@ def read_downloads(dlurl): | |||
|
|||
class DownloadCommand(Command): | |||
""" | |||
Download an OMERO artifact from a CI server. | |||
Download an OMERO artifact from either a donwloads or a Continous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: donwloads
and Continous
omego/env.py
Outdated
Add(group, "labels", "", | ||
help="Comma separated list of labels for matrix builds") | ||
help="Comma separated list of labels for matrix builds (CI only)") | ||
|
||
Add(group, "downloadurl", | ||
"http://downloads.openmicroscopy.org", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good time to change to https
Merging and re-opening gh-103 as candidates for 0.6.0 |
See ome/omero-marshal#36 (comment)
As part of the intermediate release of OMERO 5.3.0-m8, the Ice 3.5 artifacts were removed from the landing page. This caused unwanted effects on consumers of
omego
like theomero-marshal
Travis build.The root of the issue is that for release artifacts
omego download
is using the content of the index page for listing the artifacts. The logic is very fragile and easily affected by changes to the page content.This PR proposes to use the canonical
<omero_downloads_url>/artifacts
URL instead as our OMERO downloads pages have been following this convention for many years now. This should provide a listing of all the artifacts and allow regexp to filter as desired.To test this PR functionally, check that
is currently broken while with this PR
works as expected.
Depending on the needs, we might want an emergency release of
omego
with this patch although i'd like to look into ways to unit testing this detection logic. Also this has been largely tested in the context of OMERO 5.3 and thedownload
command but it might be good to review the impact on other usages ofomego
/cc @manics @jburel @joshmoore @aleksandra-tarkowska