-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make code python3 compatible #119
Conversation
The print and exception changes look fine. To get this working under Python 3 will require a lopt more changes, such as replacing removed modules such as |
from datetime import datetime | ||
import os | ||
import logging | ||
import re | ||
import ssl | ||
import urllib2 | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like this but otherwise we have to refactor all the imports
So far I have download working
and
which is OMERO related |
0260aee
to
e778f8e
Compare
@manics I believe majority is fixed now, but the problem is Travis is failing due to permission issues, not sure how to solve it, ideas? |
It's due to the removal of virtualenv. |
travis-ci/travis-ci#4260 (comment) claims system-site-packages only works with the default versions of Python, could try 3.5 instead of 3.4?
|
I tried 3.4 and 3.6, will try 3.5 then ;-) |
test/unit/test_fileutils.py
Outdated
@@ -170,7 +178,7 @@ def __init__(self, name, perms): | |||
self.mox.StubOutWithMock(os, 'chmod') | |||
|
|||
files = ['test/', 'test/a', 'test/b/', 'test/b/c'] | |||
perms = [0755, 0644, 0755, 0550] | |||
perms = [755, 644, 755, 550] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are octal, so the 0
prefix should be kept:
>>> 0755
493
>>> 755
755
1a87d0f
to
75f4a50
Compare
#122 enables full support for Python 3.6 |
Closing as per #122 (now available as a pre-release) |
This PR make code py3 compatible. Related to ome/omero-marshal#55