-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to download artifacts from Jenkins #12
Conversation
- Create standalone artifacts.py file - Add DownloadCommand to download artifacts from Hudson - Add DownloadCommand to main.py
Also move the skzipunzip check to the UpgradeCommand
choices=Artifacts.get_artifacts_list().keys(), | ||
help="The artifact to download from the CI server") | ||
|
||
Add = EnvDefault.add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a common location for the OMERO-qa-upgrade.py
-like parameters? i.e. can there be any refactoring to prevent repetition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
One option would be to use the same approach as scc and define a ArtifactsCommand
superclass.
Else we could create a JenkinsEnv
class and call JenkinsEnv.add(self.parser)
.
Any preference? alternate option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we will eventually want smarter abstract classes, but JenkinsEnv
especially if we decide to refactor jobs, use jenkinsapi
, etc. might be a good idea.
JenkinsParser wraps an existing ArgumentParser object and adds an argument group with all Jenkins related options.
Last set of commits refactor the Jenkins options under a single wrapper parser class. |
Works fine, good to merge. |
Add command to download artifacts from Jenkins
This PR adds a new
download
command toomego
to download artifacts from the CI server which should be used as followsThe major changes in this PR are the following
artifacts.py
(since thedownload
command did not fit withupgrade.py
)Artifacts.download()
does not fail if--skipunzip true
is false. TheStop()
is moved to theUpgradeCommand
insteadMore generally, should we keep maintaining our own
Artifacts
class or start using a 3d party library e.g.jenkinsapi
which already has all this logic in place including MD5 checksumming etc... /cc @manics, @joshmoore