Test omego upgrade as part of the Travis build
#14
Conversation
| @@ -21,6 +21,12 @@ before_script: | |||
| - psql -c "select 1;" -U omero -h localhost omero | |||
| - sudo mkdir /OMERO | |||
| - sudo chown $USER:$USER /OMERO | |||
| - wget http://cvs.openmicroscopy.org.uk/snapshots/omero/4.4.8p1/OMERO.server-4.4.8p1-ice34-b304.zip | |||
There was a problem hiding this comment.
For the moment, this makes good sense. I do wonder if we'll be able to come up with a download --latest-stable though.
There was a problem hiding this comment.
Fair point. Actually, it's ironic that omego upgrade cannot be used for release upgrades at the moment. Worth opening an issue?
There was a problem hiding this comment.
If omego upgrade is aimed at sysadmins (rather than devs) then the default should probably be to upgrade to releases only.
|
I think this download path is a very bad idea. As travis nodes are provided by lots of different people these requests could come from anywhere (any IP address). I do not see how they could be filtered. Would it be possible to download from a different domain that we can ignore all stats for? |
|
Or is there an option you can provide to set the download client to some string containing "ignore" we can then filter all the logs for? |
|
Would |
|
That could work, but with a speed penalty (5 times slower): http://awstats.sourceforge.net/docs/awstats_config.html#SkipReferrersBlackList |
|
I would think once we setup the "latest-downloads" we also just provide a (otherwise unused) travis URL. @qidane: can you imagine an easy-enough scheme for doing something like that? |
|
I think the right apache rewrite would handle it so you could map cvs.openmicroscopy.org/travis/snapshots to cvs.openmicroscopy.org/snapshots, but the URL could still get public. A custom user agent along with a "SkipUserAgents" directive might be the better option, but as @sbesson pointed out the help for wget says "Use of this option is discouraged, unless you really know what you are doing." :-) |
|
|
|
Test using user agent: |
|
@qidane : can we make a choice on what you want to see in the way of URLs and/or agents and get this merged? |
|
Using wget --user-agent=Travis would be best I think. AWStats can then filter out that agent. |
|
The request to www.openmicroscopy.org/info/scripts and www.openmicroscopy.org/latest/omero-manual-pdf are generating entries in our log files (302 and 303 response codes respectfully). Both are being ignored by awstats. The subsequent requests to the targets of the redirects are being counted. |
This allows an easier customization of the opening request header. This PR also allows to set the download user-agent using the USER_AGENT environment variable.
Also remove debugging line in omego/artifacts.py
|
Any more planned commits, @sbesson? |
|
Set of commits above is setting |
|
Looks fine to me. |
Test `omego upgrade` as part of the Travis build
|
In all awstats config files in /etc/awstats/ I have set SkipUserAgents="Travis Hudson" |
This PR enables the
omego upgradecommand to be tested by the Travis build:testUpgradeintegration test and run it as part of the test suiteTravis status should be 'success' meaning the test was run successfully. Upcoming steps can involve moving away the tests not requiring an OMERO instance into a separate Travis job and using Travis environments to test multiple upgrade conditions (Ice 3.3 -> Ice 3.5)
/cc @spli, @rleigh-dundee