-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download releases and non-OMERO artifacts #66
Conversation
Automatically figure out whether the argument is a jobname or release number
Since ReleaseArtifacts parses the downloads pages there's no need to use the individual latest component.zip redirects, instead we can just deference the redirect to the main release page and parse that instead.
Pre-testing, a big 👍 for the general scheme! Default behavior of |
This is mostly for internal use so its possible to use any of the following without needing additional logic (without this commit the direct server.zip url has to be passed as a separate positional argument): - omego upgrade --branch OMERO-5.1-latest - omego upgrade --branch 5.1 - omego upgrade --branch http://example.org/OMERO.server-5.1.1.zip
OMERO.cpp is no longer part of the main jobs
|
…mented)" This reverts commit e9a7260. Changed my mind on this- if you want to download a custom server you can use the existing method.
From help"
mac6 ? |
In general |
In general all works. @manics will combine this with another PR in order to have more goodies (like insight-ij download) available for testing. |
Description updated |
Also allow full-filename matching including for non-zips/non-jars
Works as expected. |
Download releases and non-OMERO artifacts
@pwalczysko: sorry for the confusion, I created a Trello card to address your comments in a follow-up PR. |
@sbesson Thanks. |
Adds
--release
as an alias for--branch
, and adds support for parsing the downloads release pages. Also adds all artifacts matching'OMERO\.(\w+).*\.zip$'
in addition to the hard-coded ones.Follow a latest redirect, then parse the downloads page:
omego download matlab -v --branch 5.1
omego download matlab -v --release 5.1
omego download matlab -v --release 5
omego download matlab -v --release 4
omego download matlab -v --release latest
Request a specific version:
omego download matlab -v --release 4.4.8
omego download matlab -v --release 5.1.3-m3
Request an artifact which is not explicitly supported in omego:
omego download java
Originally I was just downloading the zips with explicit redirects (e.g.
.../omero/server.zip
, see 0c6a111) but after implementing a downloads page html parser I realised they're no longer necessary since it's enough to follow the redirect to the page.Note release artifacts are only supported for the latest ice at present.
Updated:
More artifacts can be downloaded, see https://github.com/manics/omego/blob/17bb9e0c961f2f3aef13550a06c740cd952bcd05/omego/artifacts.py#L98 for the specification.
The following should all be equivalent:
omego download --release 5 --skipunzip python
omego download --release 5 --skipunzip py
omego download --release 5 --skipunzip OMERO.py
Partial initial matches are supported in some cases, e.g.:
omego download --release 5 --skipunzip se
will currently download the server since there are no other matching strings.Omit the artifact name to list all available:
omego download --release 5
Non-OMERO jobs are supported:
omego download --branch BIOFORMATS-5.1-merge-build
(list artifacts)omego download --branch BIOFORMATS-5.1-merge-build bftools
omego download --branch BIOFORMATS-5.1-merge-build bio
(partial match, downloads the source)Jars can be downloaded:
omego download --branch BIOFORMATS-5.1-merge-build ij
should downloadij.jar
As a last resort you can also specify the full filename in the event that the shorter names conflict, or you want to download a non-zip non-jar, e.g.
omego download --branch OMERO-5.1-latest GIT_INFO
Example output listing all zips and jars, with the shortnames which can be truncated