-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the QA upgrade script #8
Conversation
Tested locally on my Mac. I had to change Line 56 Is this a good time to clean up or delete some code, e.g. Also should this be runnable the first time the server is setup so no symlink or server is present? Currently fails in |
Ensure all ports are configured even if config.xml already exists
@manics: addressed your 2 comments. Last comment makes sense, but I would rather work on it as part of a new PR (and couple this with a Travis build testing the script) |
Good to merge. I've cc-ed you on https://trac.openmicroscopy.org.uk/ome/ticket/11282 |
Improvements to the QA upgrade script
This PR reviews the OMERO-qa-upgrade.py script to support the upgrade of multiple OMERO instances on the same Jenkins node (e.g. OMERO 4 and OMERO 5)
fix some hard-coded
OMERO-CURRENT
to systematically use theSYM
envvar across the scriptrefactor the artifact component listing using a dictionary to simplify the addition of downloadable artefacts
refactor
download_server()
into a genericdownload()
methodadd logic to call
bin/omero admin ports --prefix
using thePREFIX
environment variableset the
BUILD_ID
environment variable toDONT_KILL_ME
when called from Jenkins job to prevent server shutdown at job terminationTo be tested in the context of the OMERO-matlab-training-stable and OMERO-matlab-training-develop jobs
/cc @manics